Fix render error when removing a dashboard parameter #14999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariya
approved these changes
Feb 27, 2021
daltojohnso
force-pushed
the
dj-dashboard-param-rmv
branch
from
989a9ec
to
52827ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you click "Remove" to remove a dashboard parameter it causes an error in the render function of
DashCardCardParameterWrappercomponent because we remove the parameter from state before closing the parameter-editing view code. This causes the app to break in dev but fortunately prod is more forgiving with regards to exceptions thrown duringrendercalls. Dispatching an additional action to turn off this state fixes the issue.Verification
This is what happened in dev before the change: