-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated CircleCI image #19423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19423 +/- ##
==========================================
- Coverage 64.26% 64.25% -0.01%
==========================================
Files 2478 2479 +1
Lines 81612 81608 -4
Branches 9980 9977 -3
==========================================
- Hits 52445 52438 -7
- Misses 25049 25054 +5
+ Partials 4118 4116 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'm next to the finish line:
but I can't get yarn to spawn a java process... but I'm sure it's a path thing somewhere that I'll have to fix (EDIT: it was a missing path in the spawn process) EDIT2: I modified one of the runners from Java 16 to the latest 17 LTS |
"be-tests-ee" and "be-tests-oss" are pending since those were changed "be-tests-java-8-ee" "be-tests-java-8-oss" to know which java version we're running those tests |
ca522f3
to
eebf225
Compare
Now this should also be ready to merge once all tests pass |
3b90554
to
06c752d
Compare
06c752d
to
92b485a
Compare
0668410
to
b493c4a
Compare
|
||
FROM eclipse-temurin:11-jre-alpine as runner | ||
FROM --platform=linux/amd64 eclipse-temurin:11-jre-alpine as runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks @diogormendes for the approval, I'll need metabase/metabase-docker-ci#6 approved before merging this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't test with Clojure 1.11.0 since we're not shipping anything with it yet.
We'll probably switch to Clojure 1.11.1 when that comes out but we're still shipping 1.10.x until then
My reading of this is its just bumping the version of the clojure cli. We specify |
Thanks @dpsutton and @camsaul, I left my comments here: metabase/metabase-docker-ci#6 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops you're totally right @dpsutton. Ok in that case then this looks fine
…uilder images [ci nocache]
b493c4a
to
9ebb17e
Compare
Fixes #18650
EDIT 04-16-2022: upgraded Clojure CLI version + made the builder image multi-arch
Tests on https://app.circleci.com/pipelines/github/metabase/metabase?branch=check-new-builder&filter=all