Add missing translations #33035
Merged
Add missing translations #33035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 25be72c...5706afa.
|
WiNloSt
added
the
backport
oisincoveney
approved these changes
Aug 9, 2023
WiNloSt
commented
Aug 9, 2023
| @@ -92,7 +92,7 @@ export const getApplicationPermissionEditor = createSelector( | |||
|
|
|||
| return { | |||
| id: group.id, | |||
| name: group.name, | |||
| name: getGroupNameLocalized(group), | |||
| @@ -55,7 +55,7 @@ const getEditSegmentedAccessPostAction = (entityId, groupId, view) => | |||
| if (hasPremiumFeature("sandboxes")) { | |||
| PLUGIN_ADMIN_USER_FORM_FIELDS.push({ | |||
| name: "login_attributes", | |||
| title: "Attributes", | |||
| title: t`Attributes`, | |||
| import MappingEditor from "./MappingEditor"; | ||
|
|
||
| const LoginAttributesWidget = ({ field }) => ( | ||
| <MappingEditor | ||
| value={field.value || {}} | ||
| onChange={field.onChange} | ||
| addText="Add an attribute" | ||
| addText={t`Add an attribute`} |
| @@ -27,7 +27,7 @@ export const DataPermissionsHelp = () => { | |||
| defaultValue="database-level" | |||
| > | |||
| <Accordion.Item value="database-level"> | |||
| <Accordion.Control>Database levels</Accordion.Control> | |||
| <Accordion.Control>{t`Database levels`}</Accordion.Control> | |||
| @@ -89,19 +89,19 @@ export const CustomHomePageModal = ({ | |||
| return ( | |||
| <Modal isOpen={isOpen} onClose={onClose}> | |||
| <ModalContent | |||
| title="Customize Homepage" | |||
| title={t`Customize Homepage`} | |||
| @@ -31,13 +32,13 @@ export const HomeLayout = ({ | |||
| {hasIllustration && <LayoutIllustration />} | |||
| {hasMetabot ? <MetabotWidget /> : <HomeGreeting />} | |||
| {isAdmin && ( | |||
| <Tooltip tooltip="Pick a dashboard to serve as the homepage"> | |||
| <Tooltip tooltip={t`Pick a dashboard to serve as the homepage`}> | |||
| @@ -45,7 +45,7 @@ export function DatabasePromptBanner({ location }: DatabasePromptBannerProps) { | |||
| }} | |||
| > | |||
| <ConnectDatabaseButton small> | |||
| Connect your database | |||
| {t`Connect your database`} | |||
WiNloSt
commented
Aug 9, 2023
|
|
||
| const isPinnedGroup = (group: Group) => | ||
| isAdminGroup(group) || isDefaultGroup(group); | ||
|
|
||
| export const getOrderedGroups = createSelector( | ||
| Groups.selectors.getList, | ||
| (groups: Group[]) => _.partition(groups, isPinnedGroup), | ||
| (groups: Group[]) => { | ||
| const translatedGroups = groups.map(group => |
There was a problem hiding this comment.
Appears in
- Admin > Permissions > Data > Group
And a few other places that I'm too tired to track right now. But you can try to find the usage of getOrderedGroups to see which components this selector will be used on.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #33035 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 2995 2995
Lines 106099 106101 +2
Branches 12799 12799
=======================================
+ Hits 79406 79408 +2
Misses 21215 21215
Partials 5478 5478
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
WiNloSt
added
backport
NevRA
pushed a commit
that referenced
this pull request
Aug 14, 2023
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
Merged
Open
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing translations reported in this Slack thread
Checklist
Tests have been added/updated to cover changes in this PRNo test has been added since this is just translating existing strings in the codebase.