FE followup — LLMs for Question and Dashboard Titles and Descriptions #38298 #39147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulyk
added
no-backport
|
|
@kulyk Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
oisincoveney
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#38298) (#39147) * Missing untranslated string * Fix redundant `export` * Misc clean up * Remove duplicate block * Decouple `LLMSuestionQuestionInfo` from form * Merge loading and loaded state layouts * Extract `getSubmittableQuestion` * Compute `submittableQuestion` in save modal * Fix selectors * Fix types naming style * Fix multiple calls to summarize endpoint
|
|
||
| export const getSubmittableQuestion = (state, question) => { | ||
| const series = getTransformedSeries(state); | ||
| const resultsMetadata = getResultsMetadata(state); |
There was a problem hiding this comment.
This hasn't been 100% moved from core.js: https://github.com/metabase/metabase/blob/244ad7e/frontend/src/metabase/query_builder/actions/core/core.js#L238-L246
I'll move it as a part of #37009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FE followup on #38298, main changes:
getSubmittableQuestionfunction