Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-449 Missing config.json file crashes server with unhelpful message #401

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

anirudhjain75
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Mar 31, 2020

Thanks for opening your first pull request for BookBrainz, and welcome to our community! 🎉

If you haven't yet, please check out our contributing guidelines.

Someone will be reviewing your PR soon; just hang in there !
In the meantime, if you're wondering what to do next, you can have a look at our issue tracker

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already an improvement on the existing issue, thanks !

A minor change: with template literals (AKA template strings: my string with ${someCode}), the tabulations will be preserved in the output, so you'll end up with a somewhat malformed text in the console:
Capture d’écran 2020-04-01 à 18 00 15

The linter should allow you to simply remove the tabulation inside a multiline template literal without freaking out. It'll look a bit ugly, but I don't think that's a big problem in this case, considering how often we're likely to change that function in the future.

Capture d’écran 2020-04-01 à 18 11 07

And if you're in there, some phrasing suggestion: I don't tihnk inviting them to check if it's a directory works. The phrasing as it is kind of suggests you should have a directory, when in fact that should only happen if the file is missing.

Could not find required configuration file config/${configFileBasename}.json If you don't have a config/${configFileBasename}.json file, you should copy, rename and modify config/config.json.example. For more information refer to: https://github.com/bookbrainz/bookbrainz-site#configuration\n

@MonkeyDo
Copy link
Member

Anything I can help with for this?

@coveralls
Copy link

coveralls commented Apr 18, 2020

Coverage Status

Coverage increased (+0.1%) to 49.901% when pulling 3a2c75e on anirudhjain75:config.json-error into b3c24ce on bookbrainz:master.

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@MonkeyDo MonkeyDo merged commit 1533d03 into metabrainz:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants