Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-455: Update Flow Version #415

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

chinmay-kothari
Copy link
Contributor

Problem

Upgrading the flow version from the 0.69.0 to the latest, 0.123.0

Solution

I first removed the current flow version with sudo rm -rf path then yarn global add flow-bin@latest then after that npm install flow-bin@latest.

Areas of Impact

package.json
package-lock.json

I haven't changed the source codebase because on doing yarn create flow-upgrade --all it did following changes in around 103 files disturbing the eslint-sort:
import React from 'react'; changed to import * as React from 'react';

class Achievement extends React.Component { to class Achievement extends React.Component<$FlowFixMeProps, $FlowFixMeState> {

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.99% when pulling b2e955d on chinmay-kothari:flow_version into b09817a on bookbrainz:master.

@chinmay-kothari
Copy link
Contributor Author

@MonkeyDo
On running the local server using npm, the server is getting started with many warnings which I guess are associated with the previous flow version.
I may be totally wrong in this so can you please take a look into this. Thanks

@MonkeyDo
Copy link
Member

@chinmay-kothari Not to worry, the warnings are from ESLint, not with Flow, and they were not introduced with your PR.

However, something I haven't done in a while is run npm run flow which shows a lot of flow type errors.
If you feel like this is something you would like to tackle, you can open a new PR to try to fix some of those; it will likely be a little-by-little sort of job (just like the ESLint warnings you saw).

In any case, this PR is ready to be merged. Thanks :)

@MonkeyDo MonkeyDo merged commit b3c24ce into metabrainz:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants