Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when trying to add collection, area, editor to a collection #489

Conversation

prabalsingh24
Copy link
Contributor

Problem

If you select Editor or Area or Collection in the search results, you can press Add to collection button and it doesn't throw any error.

Solution

Screenshot_2020-08-11 Search Results – BookBrainz

@prabalsingh24
Copy link
Contributor Author

Test for this is added in the PR 477

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 58.073% when pulling a37fef9 on prabalsingh24:fix-checkEntityTypeBeforeAdding into d1fd35b on bookbrainz:UserCollection.

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !
I hadn't thought about that at all.

@MonkeyDo MonkeyDo merged commit ef27871 into metabrainz:UserCollection Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants