BB-544: Improve Editor form and error handling #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show errors, use async/await and fetch instead of superagent and promise chains, imrpove UI
Errors weren't being returned, and we needed a custom "name already in use" message.
Use state properly with onChanged events instead of using refs. This allows us to do some silmple validation on the client side. Also do some simple validation on server side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://tickets.metabrainz.org/browse/BB-544
Errors thrown are being completely swallowed by the editor profile edit form on the server and front-end, leaving the user with a spinning loader and nothing else.
Solution
First, since we're here, a bit of cleanup and renovating, moving to using await/async and fetch and such.
Second, on the server, do some validation and return better error messages.
Finally show said error messages to the user in the profile form.