Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prune dependencies #544

Merged
merged 9 commits into from
Jan 19, 2021
Merged

chore: Prune dependencies #544

merged 9 commits into from
Jan 19, 2021

Conversation

MonkeyDo
Copy link
Member

Trying to improve build times by:

  1. Removing unused dependencies
  2. Replacing seldom-used dependencies with npx … which allows running a package without having it installed as a dependency in the project
  3. Move dependencies to dev-dependencies if only used for dev/build
  4. Reduce Docker image build time (better layer caching) and image size (pruning dev dependencies after build)

@coveralls
Copy link

coveralls commented Dec 17, 2020

Coverage Status

Coverage decreased (-0.02%) to 60.922% when pulling 5b05aca on prune-dependencies into 12884da on master.

Only used in an old test file, and we have an alternative we use everywhere else (chai-http)
Move packages required for runtime out of devDependencies
with the help of the depcheck npm package.
Replaces some CI tasks dependencies with npx (npm package runner)
Also pass  --fix flag to eslint precommit hook.
Use git directly instead to write hash to file during docker build. The hash is already passed in dockerfile at build-time.
Less likely to change over time (compared to 'npm install'), which means better caching and faster build time.
Requires to keep git around as it is used during npm install.
all about the deps, PR 544
Replaced with github action
@MonkeyDo MonkeyDo merged commit 8268aae into master Jan 19, 2021
@MonkeyDo MonkeyDo deleted the prune-dependencies branch January 19, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants