Adding mailing service to the codebase

[endurance21]

Problem

There was no mailing agent dedicated for the codebase.

Solution

Implement one such agent.
This pr deals with setting up node-mailer as our mailing agent.

Areas of Impact

server
global config file

[endurance21]

@MonkeyDo lint tests are failing , and one of them is due to
Async function 'sendEmail' has no 'await' expression
should i bypass this?
or should i remove async keyword cz anyway this function gonna return promise 🤔

[MonkeyDo]

@MonkeyDo lint tests are failing , and one of them is due to
Async function 'sendEmail' has no 'await' expression
should i bypass this?
or should i remove async keyword cz anyway this function gonna return promise 🤔

Removing the async keyword is the way to go here.

[MonkeyDo]

You'll also need to commit the package-lock.json file in order for the tests to pass.

[endurance21]

done the changes , please have a look @MonkeyDo

[coveralls]

Coverage decreased (-0.02%) to 60.9% when pulling f2aa07a on endurance21:feature/mailer into 95365c5 on bookbrainz:master.

[endurance21]

i have run npm run lint locally but found no error !
how this test is not passing

[MonkeyDo]

Not sure what's happening with the linter, but we'll see if the next push passes. If not we'll ignore them as the dependency is indeed in package.json

[endurance21]

@MonkeyDo
i have done the chnages , looking forward for the process :)

[MonkeyDo]

Looking pretty good !

The file mailer.js needs to be removed, now that you've created the .ts file.

[endurance21]

Have to lint it properly once !

[endurance21]

@MonkeyDo i think this one is ready to go !

[MonkeyDo]

Great, thanks !