Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(revision): Added merged badge to mark merged entities in a revision #608

Merged
merged 4 commits into from
Apr 28, 2021
Merged

feat(revision): Added merged badge to mark merged entities in a revision #608

merged 4 commits into from
Apr 28, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Apr 26, 2021 •
edited
Loading

Problem

Follow Up from PR: #602
In the Merge Entity section of revison page, merged entities are marked with deleted badge.

Screenshot from 2021-04-26 21-28-22

Solution

Added Merged badge to mark merged entities in a revision.

Screenshot from 2021-04-26 21-24-27

Areas of Impact

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 60.804% when pulling 86c7141 on akashgp09:merge-badge into 82e5222 on bookbrainz:master.

MonkeyDo
MonkeyDo approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks ! That rounds up the feature nicely!

@MonkeyDo MonkeyDo merged commit 84cba48 into metabrainz:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashgp09 @coveralls @MonkeyDo