Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: proptypes mismatch and invalid DOM property warning #615

Merged
merged 1 commit into from
May 3, 2021
Merged

FIX: proptypes mismatch and invalid DOM property warning #615

merged 1 commit into from
May 3, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Apr 30, 2021 •
edited
Loading

Signed-off-by: Akash Gupta akashgp9@gmail.com

Problem

Screenshot from 2021-04-30 20-05-49

Solution

updated propTypes and fixed invalid DOM property warning

Areas of Impact

@akashgp09
fix:proptypes mismatch and invalid DOM property
7103cff 
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@akashgp09 akashgp09 changed the title FIX: proptypes mismatch and invalid DOM property FIX: proptypes mismatch and invalid DOM property warning Apr 30, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.804% when pulling 7103cff on akashgp09:props into 84cba48 on bookbrainz:master.

MonkeyDo
MonkeyDo approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an easy merge, thank you !

@MonkeyDo MonkeyDo merged commit a0e8960 into metabrainz:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashgp09 @coveralls @MonkeyDo