feat(series,relationship): show revision history for series and relationship attributes #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains a PR for the addition of relationship attributes to revision diffs
MonkeyDo
requested changes
Jul 29, 2021
There was a problem hiding this comment.
I think there are still some issues to iron out, but this is already working pretty well.
I updated the bookbrainz-data-js package and deployed this on test.bookbrainz.
I'm seeing no diffs changes in two revisions: https://test.bookbrainz.org/revision/29907 and https://test.bookbrainz.org/revision/29908
Each revision has a note explaining what I changed.
The attributes do appear on some revisions, but I think only when the relationship is created. For example: https://test.bookbrainz.org/revision/29905
I think this may be because in the formatRelationship function we detect addition and removal of relationships, but not modifications?
MonkeyDo
approved these changes
Aug 16, 2021
akashgp09
changed the title
akashgp09
changed the title
akashgp09
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show revision diffs for series and relationship atrributes.