Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set relationship attributes value in relationship-editor #684

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

akashgp09
Copy link
Contributor

Summary:

Set relationship attributes value in relationship-editor.

Screenshot from 2021-08-04 07-37-13

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 61.469% when pulling 964b9c0 on akashgp09:relationship-attributes into fd718f5 on bookbrainz:series-entity.

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are paving the way for more relationship attributes! :)

@akashgp09
Copy link
Contributor Author

Alright, @MonkeyDo I realized some mistakes in my Implementation. We don't need to set position value inside handleNumberAttributeChange. I have removed it now 😅

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking it over !

@MonkeyDo MonkeyDo merged commit 0475a73 into metabrainz:series-entity Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants