FIX: Do not mutate the relationshipsTypes array.

[akashgp09]

Problem

Uncaught TypeError: Cannot set property 'attributes' of undefined

Steps to reproduce:

1. Navigate to /series/create endpoint.
2. Add a relationship.
3. Then add a series item.

Cause:

When you add a relationship, the relationshipTypes array gets mutated here and the relationship type 69-74 is permanently removed. And then when you come back to the series editor, and tries to add a item to the series, the relationship type 69-74 is not present this time in the relationshipTypes array here, hence leading to an error.

Solution

Do not mutate the relationshipsTypes array.

Areas of Impact

https://github.com/bookbrainz/bookbrainz-site/blob/series-entity/src/client/entity-editor/relationship-editor/relationship-editor.tsx

[MonkeyDo]

Good find, good fix!

Do we have a similar situation here or is the mutation required?: https://github.com/bookbrainz/bookbrainz-site/blob/series-entity/src/server/helpers/middleware.ts#L83

[akashgp09]

Do we have a similar situation here or is the mutation required?: https://github.com/bookbrainz/bookbrainz-site/blob/series-entity/src/server/helpers/middleware.ts#L83

Yeah, mutating the array there is intentional. It will remove the series items from the relationships array, so that series items do not show up in the Relationships section of Series page.