Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[BB-635]: adding check for deleted entity #734

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix[BB-635]: adding check for deleted entity #734

merged 1 commit into from
Dec 21, 2021

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Dec 5, 2021 •
edited
Loading

Problem

BB-635: Website crashes due to not handling already deleted entity case.

Solution

return 409 response code

Areas of Impact

  1. src/server/routes/entity/entity.tsx

MonkeyDo
MonkeyDo approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! 🚀

@MonkeyDo MonkeyDo merged commit 3d65c8e into metabrainz:master Dec 21, 2021
@tr1ten tr1ten deleted the fix#BB-635 branch January 27, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tr1ten @MonkeyDo