Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(BB-555): warn user on beforeunload event #741

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Feat(BB-555): warn user on beforeunload event #741

merged 7 commits into from
Mar 2, 2022

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Dec 16, 2021 •
edited
Loading

Problem

BB-555 : warn user before closing entity editor if changes made

Solution

using redux store to get finalState, if changes made then warn user on beforeunload event

warning

Areas of Impact

  1. src/client/entity-editor/entity-editor.tsx

@tr1ten tr1ten marked this pull request as ready for review January 4, 2022 15:04
MonkeyDo
MonkeyDo requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small modification below, but everything is working absolutely great, thanks for working on this !

src/client/entity-editor/entity-editor.tsx Outdated Show resolved Hide resolved
@MonkeyDo
Copy link
Member

MonkeyDo commented Mar 2, 2022

Thank you so much !
I'll merge and deploy this to beta.

@MonkeyDo MonkeyDo merged commit f957dc4 into metabrainz:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tr1ten @MonkeyDo