Maintenance updates #749
Merged
Maintenance updates #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftmostcat
commented
Dec 23, 2021
| @@ -73,6 +73,7 @@ | |||
| "react-sortable-hoc": "^2.0.0", | |||
| "react-sticky": "^6.0.1", | |||
| "react-virtualized-select": "^3.0.1", | |||
| "redis": "^3.1.2", | |||
There was a problem hiding this comment.
connect-redis v4+ no longer bundle redis.
leftmostcat
commented
Dec 23, 2021
src/api/app.js
Outdated
| @@ -49,6 +50,10 @@ app.use(express.json()); | |||
| app.use(express.urlencoded({extended: false})); | |||
| app.use(compression()); | |||
|
|
|||
| const redisClient = createClient({ | |||
There was a problem hiding this comment.
Due to connect-redis no longer bundling redis, we now have to create the client ourselves and pass it in, here and in the server app.
MonkeyDo
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Several dependencies are out-of-date and have transitive dependencies with security issues.
Solution
Update
swagger-ui-express,connect-redis, andlog-node.Areas of Impact
App connectors.