Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph date fix #751

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Graph date fix #751

merged 2 commits into from
Jan 24, 2022

Conversation

shalini-bhandari
Copy link
Contributor

Problem

https://tickets.metabrainz.org/browse/BB-551

Solution

In user activity graph of editor Monkey, after the current month revisions the graph was showing revisions of year 2015 and 2016 i.e., dates in graph starts from the day of joining but because there were some revisions that were of before the joining date hence dates in graph were not sorted
To make sure the dates are in correct order I changed the start condition of the graph.
condition is: if the joining date of the editor is greater than the first revision then graph will start from date of first revision otherwise it will start from the joining date.

Areas of Impact

@welcome
Copy link

welcome bot commented Dec 29, 2021

Thanks for opening your first pull request for BookBrainz, and welcome to our community! 🎉

If you haven't yet, please check out our contributing guidelines.

Someone will be reviewing your PR soon; just hang in there !
In the meantime, if you're wondering what to do next, you can have a look at our issue tracker

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see !
This shouldn't ever happen (having revisions before creating an account), but I must havve made some manual modifications to the database that led to this edge-case.

Thanks a lot for fixing this, and for unearthing a more problematic issue !

@MonkeyDo MonkeyDo merged commit 3cf5dba into metabrainz:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants