Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bs4): Place tooltips to the right in modal header #789

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

MonkeyDo
Copy link
Member

@MonkeyDo MonkeyDo commented Mar 1, 2022

Problem

Tooltips are rendered by default on top of their OverlayTrigger, and for modal headers the tooltips appear mostly off-screen:
image

Solution

Adds placement="right" property to OverlayTrigger components that appear in modal headers.
Other OverlayTriggers remain untouched as we don't have the issue mentioned above.

image

Areas of Impact

src/client/components/forms/deletion.js
src/client/entity-editor/alias-editor/alias-editor.js
src/client/entity-editor/identifier-editor/identifier-editor.js

Otherwise they are rendered by default on top, and for modal headers the tooltips appear mostly off-screen
@MonkeyDo
Copy link
Member Author

MonkeyDo commented Mar 1, 2022

Last fixes before deploying the Bootstrap4 update to prod, along with LordSputnik/lobes#1

@LordSputnik
Copy link
Member

Looks good to me! I think I did something like this locally at one point, but didn't keep it for some reason...

@LordSputnik LordSputnik merged commit 1d9f1d7 into master Mar 1, 2022
@LordSputnik LordSputnik deleted the monkey-fix-tooltip-position branch March 1, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants