feat(entity-editor): search for duplicates when pre-filling name #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using query parameters to pre-fill the name of a new entity, we trigger a search for possible duplicates, as we do when user types the name.
These become Lists in Redux and need to be converted accordingly at the other end.
MonkeyDo
force-pushed
the
search-initial-pre-filled-name
branch
from
bffa5bf
to
ff8c970
Compare
MonkeyDo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #800 I realized we have the same issue with the duplicate search:
When creating a new entity, the search for possible duplicates is only triggered when when user types in the name input.
When using query parameters to pre-fill the name of a new entity, that doesn't happen, leading to possible dupes.
With this PR we trigger a search for possible duplicates when we render the props to send to the user.