fix(language-select): Fix filtering of language select options #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select is crazy slow on older browsers due to issues with filtering the gigantic list of options. With the react-select-fast-filter-options library this is easily fixed.
|
seems good to me :) |
tr1ten
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The select is crazy slow on older browsers due to issues with filtering the gigantic list of options.
The default filtering of react-select is inefficient
Solution
Using the library react-select-fast-filter-options fixes the issue.
It uses js-search under the hood which is more efficient.
Areas of Impact
src/client/entity-editor/common/language-field.tsx
package.json and yarn lockfile