BB-721: Add placeholder text for empty sections

[Bigguysahaj]

Problem

Solved the problem of placeholder text for empty sections and call to action for creating new collections, identifiers, and relationships.

As mentioned in the ticket
https://tickets.metabrainz.org/browse/BB-721?jql=labels%20%3D%20good-first-bug%20ORDER%20BY%20created%20DESC
and the pull request #947

Solution

Before:

After:

I added placeholder text, along with a link that directs users directly to the /edit endpoint.

Areas of Impact

Main areas of impact were the EntityRelatedCollections , EntityRelationships & EntityIdentifiers functions.

[kellnerd]

@Bigguysahaj When you change this PR's title to the correct format "BB-721: Add placeholder text for empty sections" it will automatically be linked to the JIRA ticket.

[Bigguysahaj]

@Bigguysahaj When you change this PR's title to the correct format "BB 721: Add placeholder text for empty sections" it will automatically be linked to the JIRA ticket.

Ohh I'm sorry, thanks tons I will fix it.

[kellnerd]

No problem, we all make mistakes... just as I did when I forgot the hyphen between BB and the ticket number in my above suggestion. Please change it again to "BB-721: Add placeholder text for empty sections" and it should work for real 😅

[Bigguysahaj]

No problem, we all make mistakes... just as I did when I forgot the hyphen between BB and the ticket number in my above suggestion. Please change it again to "BB-721: Add placeholder text for empty sections" and it should work for real 😅

@kellnerd could you please help me understand how to fix these ESLint errors, and further more how to go about to get my PR merged?

[kellnerd]

Well, the ESLint errors tell you where you haven't formatted the code correctly. So you have to format it to fulfil ESLint's expectations in order to make the errors disappear.
Just google the error messages which you don't understand or look them up in the ESLint docs.
You can also run ESLint locally to check whether you've fixed all errors, simply run npm's lint script command to do that, e.g. by executing npm run lint.

After fixing the errors you have to be patient and wait until someone with merge priviledges (i.e. not me) reviews your PR.

[allgandalf]

No problem, we all make mistakes... just as I did when I forgot the hyphen between BB and the ticket number in my above suggestion. Please change it again to "BB-721: Add placeholder text for empty sections" and it should work for real sweat_smile

@kellnerd could you please help me understand how to fix these ESLint errors, and further more how to go about to get my PR merged?

Hey @Bigguysahaj, there is Indentation problem and some syntax errors in your submitted PR, fix the indentation while your PR gets reviewed.

[Bigguysahaj]

Thanks alot, I will fix that. @RohanSasne

[MonkeyDo]

Hello @Bigguysahaj !

Would you like to continue on this PR?
Let me know if you need any help or advice :)

[Bigguysahaj]

I think I fixed the Eslint and some basic errors, thanks to Kellnerd and Rohan.
Is this PR okay? and should I squash all my commits into one?

[allgandalf]

well i guess, it would be okay, the changes are clear and readable so i don’t think that’s an issue, but let monkey have a say in this 😁

[Bigguysahaj]

Okay, @MonkeyDo, could you please review the changes and let me know if I need to do something else?

[MonkeyDo]

Thank you for coming back to it !

I have some wording suggestions as well as some small nitpicking, but overall this does a great job already, thank you :)

[Bigguysahaj]

Thank you for coming back to it !

I have some wording suggestions as well as some small nitpicking, but overall this does a great job already, thank you

Thank you for reviewing, it was really helpful : )
I had no idea you could use this

{relationships?.length > 0 ? (

instead of

{relationships && relationships.length > 0 ? (

[MonkeyDo]

Good to go, thank you very much !