Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10793: Convert historic Move Release edit to React #1483

Merged
merged 1 commit into from May 20, 2020
Merged

MBS-10793: Convert historic Move Release edit to React #1483

merged 1 commit into from May 20, 2020

Conversation

reosarevok
Copy link
Member

Implement MBS-10793

Changes from the TT:

Actually attempt to link the artists if possible, rather than just printing their names. That might be because a fair amount of them have their IDs missing (one example had Metallica with an ID of 0) but we should still try to link them where we can.

Additionally, this actually tries to pass move_tracks to the template - it was trying to load it from display_data but AFAICT it wasn't being added to display_data at all. Not sure if it's ever not false, but just in case.

On top of #1482

@reosarevok reosarevok added the React PRs directly related with React conversion label Apr 28, 2020
@reosarevok reosarevok mentioned this pull request Apr 29, 2020
Merged
yvanzo
yvanzo approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, this actually tries to pass move_tracks to the template - it was trying to load it from display_data but AFAICT it wasn't being added to display_data at all. Not sure if it's ever not false, but just in case.

Might it be move_tracks has been added to display_data later on?
Here is at least one example you fixed:

@reosarevok
MBS-10793: Convert historic Move Release edit to React
0136cdc 
Changes from the TT:

Actually attempt to link the artists if possible, rather than just
printing their names. That might be because a fair amount of them
have their IDs missing (one example had Metallica with an ID of 0)
but we should still try to link them where we can.

Additionally, this actually tries to pass move_tracks to the template -
it was trying to load it from display_data but AFAICT it wasn't
being added to display_data at all. Not sure if it's ever not false,
but just in case.
@reosarevok
Copy link
Member Author

Oh, nice, so I guess it did get added sometimes, but because it wasn't passed to display_data at all, it showed nothing anyway.

@reosarevok reosarevok merged commit 5a9be7a into metabrainz:master May 20, 2020
@reosarevok reosarevok deleted the MBS-10793 branch May 20, 2020 15:00
yvanzo added a commit that referenced this pull request May 26, 2020
@yvanzo
Merge branch 'master' into beta
a509d25 
* master:
  Update POT files using the production database
  Update translations from Transifex
  MBS-10817: Convert Edit Label edit to React (#1507)
  MBS-10845: User lookup tools for account admins (#1529)
  MBS-10839: Add merge button to recording list in artist overview (#1522)
  Replace musicbrainz-vm with musicbrainz-docker (#1526)
  MBS-10834: Account flag to disable writing edit notes
  MBS-10842: Remove report link from deleted editors (#1523)
  MBS-10841: Add "Guess case" per medium (#1524)
  MBS-10840: Fix key names in English guess case (#1525)
  Only load removeFromMergeColumn if needed
  Avoid null headers in react-table
  Bump react-table version to 7.1.0
  MBS-10813: Update the Bandcamp logo (#1502)
  Remove extra space
  MBS-10799: Convert historic Move Release to RG edit to React
  MBS-10793: Convert historic Move Release edit to React (#1483)
  MBS-10838: Also display editing-disabled banner on React pages
  MBS-10412: Allow niconico channel (ch.) links
  MBS-10831: Allow niconico user links for all videochannel rels
  MBS-9516: Error message for Wikipedia-as-discography
  MBS-9516: Error message for no-deeplinking images
  MBS-9516: Add explanation for blocked tweet links
  MBS-9516: Add error msg for iTunes release link on artist
  MBS-9516: Explain why some Instagram links are blocked
  MBS-9516: Add explanation for Discogs master links
  MBS-9516: Add error for Bigcartel product on artist
  MBS-9516: Error messages for Bandcamp pages
  MBS-9516: Add error for Allmusic album/release confusion
  MBS-9516: Add explanatory errors for video relationships
  MBS-10785: Remove FreeDB Gateway from menu (#1478)
  Removing duplicate dependency
  Eslint: unexpected trailing delimiter
  MBS-10822: Change tableColumns tables to use named parameters
  MBS-9516: Replace MBS-9515 error with new error option
  MBS-9516: Support custom validation errors in URLCleanup
  Updated Facebook, Google Play, and Spotify icons. (#1516)
  MBS-10397: Convert Edit Event edit to React (#1505)
  MBS-7822: Update OverClocked ReMix favicon (#1509)
  Fix crashes in historical edits
  MBS-10399: Convert Edit Recording edit to React
  MBS-7781: Add script to merge duplicate artist credits
yvanzo added a commit that referenced this pull request Jun 2, 2020
@yvanzo
Merge branch 'beta' into production
49761e4 
* beta:
  Update translations from Transifex
  Fix typo preventing to store alert_mtime on beta
  Add colon instead of brackets to row header
  Update POT files using the production database
  Update translations from Transifex
  Link to input clean album URL from error message
  Return error message only when an error occurred
  Drop unneeded space and key attribute
  Quote URL patterns that should not be localized
  Typo: Add missing full stop to error message
  Fix error message for Instagram’s explore links
  Use bracketedText to reuse localizable message
  MBS-10849: Check for allowNew on AddReleaseGroup (#1530)
  MBS-10850: Update BadAmazonURLs report to avoid false positives (#1534)
  MBS-10863: Use new_barcode instead of undef barcode (#1535)
  MBS-8412: Standardize pagination limits (#1467)
  MBS-10855: Show [removed] recording in historic EditTrack (#1532)
  MBS-10613: Only show git info on staging servers (#1510)
  MBS-10853: Include link to subbed users' open edits in sub email (#1533)
  MBS-10727: Drop kasi-time.com from lyrics whitelist (#1537)
  MBS-10732: Add collaborator validation to collection form (#1496)
  Reference MB Solr and SIR in install doc
  MBH-502: SOLR access via search.mb.org/ws/2
  MBS-10789: Add validation for Genius links
  MBS-9963: Update Genius logo
  MBS-9963: Update Genius link format
  Do not sleep after updating the last host
  Fix defining alert cache keys for the beta website
  Restore distinguishing banner for the beta website
  Sleep 60 seconds more when deploying beta
  Fix defining alert cache keys for the beta website
  Restore distinguishing banner for the beta website
  Update POT files using the production database
  Update translations from Transifex
  MBS-10817: Convert Edit Label edit to React (#1507)
  MBS-10845: User lookup tools for account admins (#1529)
  MBS-10839: Add merge button to recording list in artist overview (#1522)
  Replace musicbrainz-vm with musicbrainz-docker (#1526)
  MBS-10834: Account flag to disable writing edit notes
  MBS-10842: Remove report link from deleted editors (#1523)
  MBS-10841: Add "Guess case" per medium (#1524)
  MBS-10840: Fix key names in English guess case (#1525)
  Only load removeFromMergeColumn if needed
  Avoid null headers in react-table
  Bump react-table version to 7.1.0
  MBS-10813: Update the Bandcamp logo (#1502)
  Remove extra space
  MBS-10799: Convert historic Move Release to RG edit to React
  MBS-10793: Convert historic Move Release edit to React (#1483)
  MBS-10838: Also display editing-disabled banner on React pages
  MBS-10412: Allow niconico channel (ch.) links
  MBS-10831: Allow niconico user links for all videochannel rels
  MBS-9516: Error message for Wikipedia-as-discography
  MBS-9516: Error message for no-deeplinking images
  MBS-9516: Add explanation for blocked tweet links
  MBS-9516: Add error msg for iTunes release link on artist
  MBS-9516: Explain why some Instagram links are blocked
  MBS-9516: Add explanation for Discogs master links
  MBS-9516: Add error for Bigcartel product on artist
  MBS-9516: Error messages for Bandcamp pages
  MBS-9516: Add error for Allmusic album/release confusion
  MBS-9516: Add explanatory errors for video relationships
  MBS-10785: Remove FreeDB Gateway from menu (#1478)
  Removing duplicate dependency
  Eslint: unexpected trailing delimiter
  MBS-10822: Change tableColumns tables to use named parameters
  MBS-9516: Replace MBS-9515 error with new error option
  MBS-9516: Support custom validation errors in URLCleanup
  Updated Facebook, Google Play, and Spotify icons. (#1516)
  MBS-10397: Convert Edit Event edit to React (#1505)
  MBS-7822: Update OverClocked ReMix favicon (#1509)
  Fix crashes in historical edits
  MBS-10399: Convert Edit Recording edit to React
  MBS-7781: Add script to merge duplicate artist credits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek approved these changes

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
React PRs directly related with React conversion
Projects
None yet
Milestone
No milestone
3 participants
@reosarevok @mwiencek @yvanzo