MBS-10732: Add collaborator validation to collection form #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanzo
requested changes
May 5, 2020
reosarevok
force-pushed
the
MBS-10732
branch
2 times, most recently
from
2e239d5
to
bb90fe3
Compare
mwiencek
requested changes
May 21, 2020
Up until now a user could type in an editor name in the collaborators field for a collection and try to submit without selecting a result, leading to an ISE. The error field is special-cased to remove the margin because otherwise a margin of over 160px makes it look absurd. Also, inputName for the autocomplete was incorrect, so this fixes that.
mwiencek
approved these changes
May 28, 2020
yvanzo
added a commit
that referenced
this pull request
May 28, 2020
* master: Update POT files using the production database Update translations from Transifex Link to input clean album URL from error message Return error message only when an error occurred Drop unneeded space and key attribute Quote URL patterns that should not be localized Typo: Add missing full stop to error message Fix error message for Instagram’s explore links Use bracketedText to reuse localizable message MBS-10849: Check for allowNew on AddReleaseGroup (#1530) MBS-10850: Update BadAmazonURLs report to avoid false positives (#1534) MBS-10863: Use new_barcode instead of undef barcode (#1535) MBS-8412: Standardize pagination limits (#1467) MBS-10855: Show [removed] recording in historic EditTrack (#1532) MBS-10613: Only show git info on staging servers (#1510) MBS-10853: Include link to subbed users' open edits in sub email (#1533) MBS-10727: Drop kasi-time.com from lyrics whitelist (#1537) MBS-10732: Add collaborator validation to collection form (#1496) Reference MB Solr and SIR in install doc MBH-502: SOLR access via search.mb.org/ws/2 MBS-10789: Add validation for Genius links MBS-9963: Update Genius logo MBS-9963: Update Genius link format Do not sleep after updating the last host Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Sleep 60 seconds more when deploying beta
yvanzo
added a commit
that referenced
this pull request
Jun 2, 2020
* beta: Update translations from Transifex Fix typo preventing to store alert_mtime on beta Add colon instead of brackets to row header Update POT files using the production database Update translations from Transifex Link to input clean album URL from error message Return error message only when an error occurred Drop unneeded space and key attribute Quote URL patterns that should not be localized Typo: Add missing full stop to error message Fix error message for Instagram’s explore links Use bracketedText to reuse localizable message MBS-10849: Check for allowNew on AddReleaseGroup (#1530) MBS-10850: Update BadAmazonURLs report to avoid false positives (#1534) MBS-10863: Use new_barcode instead of undef barcode (#1535) MBS-8412: Standardize pagination limits (#1467) MBS-10855: Show [removed] recording in historic EditTrack (#1532) MBS-10613: Only show git info on staging servers (#1510) MBS-10853: Include link to subbed users' open edits in sub email (#1533) MBS-10727: Drop kasi-time.com from lyrics whitelist (#1537) MBS-10732: Add collaborator validation to collection form (#1496) Reference MB Solr and SIR in install doc MBH-502: SOLR access via search.mb.org/ws/2 MBS-10789: Add validation for Genius links MBS-9963: Update Genius logo MBS-9963: Update Genius link format Do not sleep after updating the last host Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Sleep 60 seconds more when deploying beta Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Update POT files using the production database Update translations from Transifex MBS-10817: Convert Edit Label edit to React (#1507) MBS-10845: User lookup tools for account admins (#1529) MBS-10839: Add merge button to recording list in artist overview (#1522) Replace musicbrainz-vm with musicbrainz-docker (#1526) MBS-10834: Account flag to disable writing edit notes MBS-10842: Remove report link from deleted editors (#1523) MBS-10841: Add "Guess case" per medium (#1524) MBS-10840: Fix key names in English guess case (#1525) Only load removeFromMergeColumn if needed Avoid null headers in react-table Bump react-table version to 7.1.0 MBS-10813: Update the Bandcamp logo (#1502) Remove extra space MBS-10799: Convert historic Move Release to RG edit to React MBS-10793: Convert historic Move Release edit to React (#1483) MBS-10838: Also display editing-disabled banner on React pages MBS-10412: Allow niconico channel (ch.) links MBS-10831: Allow niconico user links for all videochannel rels MBS-9516: Error message for Wikipedia-as-discography MBS-9516: Error message for no-deeplinking images MBS-9516: Add explanation for blocked tweet links MBS-9516: Add error msg for iTunes release link on artist MBS-9516: Explain why some Instagram links are blocked MBS-9516: Add explanation for Discogs master links MBS-9516: Add error for Bigcartel product on artist MBS-9516: Error messages for Bandcamp pages MBS-9516: Add error for Allmusic album/release confusion MBS-9516: Add explanatory errors for video relationships MBS-10785: Remove FreeDB Gateway from menu (#1478) Removing duplicate dependency Eslint: unexpected trailing delimiter MBS-10822: Change tableColumns tables to use named parameters MBS-9516: Replace MBS-9515 error with new error option MBS-9516: Support custom validation errors in URLCleanup Updated Facebook, Google Play, and Spotify icons. (#1516) MBS-10397: Convert Edit Event edit to React (#1505) MBS-7822: Update OverClocked ReMix favicon (#1509) Fix crashes in historical edits MBS-10399: Convert Edit Recording edit to React MBS-7781: Add script to merge duplicate artist credits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-10732
Up until now a user could type in an editor name in the collaborators field for a collection and try to submit without selecting a result, leading to an ISE.
The error field is special-cased to remove the margin because otherwise a margin of over 160px makes it look absurd.
Also, inputName for the autocomplete was incorrect, so this fixes that.