-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-8412: Standardize pagination limits #1467
Conversation
We have different pagination limits for different edit pages, which leads to situations like artist/mbid/edits showing 100 edits but the edit search reached when clicking "Refine this search" (which a user would no doubt expect to be equivalent, until they refine it) only showing the first 25 of them. This standardises all of those lists to 100, which is our default pagination limit anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird that they're different. 100 seems high, but you're probably right that it won't be an issue given all the places it's already used. (Since you can construct edit searches that are quite slow, maybe having a small limit is bad if it makes you have to keep advancing pages?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* master: Update POT files using the production database Update translations from Transifex Link to input clean album URL from error message Return error message only when an error occurred Drop unneeded space and key attribute Quote URL patterns that should not be localized Typo: Add missing full stop to error message Fix error message for Instagram’s explore links Use bracketedText to reuse localizable message MBS-10849: Check for allowNew on AddReleaseGroup (#1530) MBS-10850: Update BadAmazonURLs report to avoid false positives (#1534) MBS-10863: Use new_barcode instead of undef barcode (#1535) MBS-8412: Standardize pagination limits (#1467) MBS-10855: Show [removed] recording in historic EditTrack (#1532) MBS-10613: Only show git info on staging servers (#1510) MBS-10853: Include link to subbed users' open edits in sub email (#1533) MBS-10727: Drop kasi-time.com from lyrics whitelist (#1537) MBS-10732: Add collaborator validation to collection form (#1496) Reference MB Solr and SIR in install doc MBH-502: SOLR access via search.mb.org/ws/2 MBS-10789: Add validation for Genius links MBS-9963: Update Genius logo MBS-9963: Update Genius link format Do not sleep after updating the last host Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Sleep 60 seconds more when deploying beta
* beta: Update translations from Transifex Fix typo preventing to store alert_mtime on beta Add colon instead of brackets to row header Update POT files using the production database Update translations from Transifex Link to input clean album URL from error message Return error message only when an error occurred Drop unneeded space and key attribute Quote URL patterns that should not be localized Typo: Add missing full stop to error message Fix error message for Instagram’s explore links Use bracketedText to reuse localizable message MBS-10849: Check for allowNew on AddReleaseGroup (#1530) MBS-10850: Update BadAmazonURLs report to avoid false positives (#1534) MBS-10863: Use new_barcode instead of undef barcode (#1535) MBS-8412: Standardize pagination limits (#1467) MBS-10855: Show [removed] recording in historic EditTrack (#1532) MBS-10613: Only show git info on staging servers (#1510) MBS-10853: Include link to subbed users' open edits in sub email (#1533) MBS-10727: Drop kasi-time.com from lyrics whitelist (#1537) MBS-10732: Add collaborator validation to collection form (#1496) Reference MB Solr and SIR in install doc MBH-502: SOLR access via search.mb.org/ws/2 MBS-10789: Add validation for Genius links MBS-9963: Update Genius logo MBS-9963: Update Genius link format Do not sleep after updating the last host Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Sleep 60 seconds more when deploying beta Fix defining alert cache keys for the beta website Restore distinguishing banner for the beta website Update POT files using the production database Update translations from Transifex MBS-10817: Convert Edit Label edit to React (#1507) MBS-10845: User lookup tools for account admins (#1529) MBS-10839: Add merge button to recording list in artist overview (#1522) Replace musicbrainz-vm with musicbrainz-docker (#1526) MBS-10834: Account flag to disable writing edit notes MBS-10842: Remove report link from deleted editors (#1523) MBS-10841: Add "Guess case" per medium (#1524) MBS-10840: Fix key names in English guess case (#1525) Only load removeFromMergeColumn if needed Avoid null headers in react-table Bump react-table version to 7.1.0 MBS-10813: Update the Bandcamp logo (#1502) Remove extra space MBS-10799: Convert historic Move Release to RG edit to React MBS-10793: Convert historic Move Release edit to React (#1483) MBS-10838: Also display editing-disabled banner on React pages MBS-10412: Allow niconico channel (ch.) links MBS-10831: Allow niconico user links for all videochannel rels MBS-9516: Error message for Wikipedia-as-discography MBS-9516: Error message for no-deeplinking images MBS-9516: Add explanation for blocked tweet links MBS-9516: Add error msg for iTunes release link on artist MBS-9516: Explain why some Instagram links are blocked MBS-9516: Add explanation for Discogs master links MBS-9516: Add error for Bigcartel product on artist MBS-9516: Error messages for Bandcamp pages MBS-9516: Add error for Allmusic album/release confusion MBS-9516: Add explanatory errors for video relationships MBS-10785: Remove FreeDB Gateway from menu (#1478) Removing duplicate dependency Eslint: unexpected trailing delimiter MBS-10822: Change tableColumns tables to use named parameters MBS-9516: Replace MBS-9515 error with new error option MBS-9516: Support custom validation errors in URLCleanup Updated Facebook, Google Play, and Spotify icons. (#1516) MBS-10397: Convert Edit Event edit to React (#1505) MBS-7822: Update OverClocked ReMix favicon (#1509) Fix crashes in historical edits MBS-10399: Convert Edit Recording edit to React MBS-7781: Add script to merge duplicate artist credits
Implement MBS-8412
We have different pagination limits for different edit pages, which leads to situations like artist/mbid/edits showing 100 edits but the edit search reached when clicking "Refine this search"
(which a user would no doubt expect to be equivalent, until they refine it) only showing the first 25 of them.
This standardises all of those 25-edit lists to 100, our default pagination limit.
If this seems like too much for some reason then we could change all edit listings to show 50, but I think 100 should be doable since it was already used in most places anyway.