Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10816: Convert Add Label Edit to React #1506

Merged
merged 1 commit into from
Jun 30, 2020
Merged

MBS-10816: Convert Add Label Edit to React #1506

merged 1 commit into from
Jun 30, 2020

Conversation

anirudhjain75
Copy link
Contributor

No description provided.

@anirudhjain75 anirudhjain75 force-pushed the add-label branch 2 times, most recently from 6e54e08 to 70e00d1 Compare May 10, 2020 07:23
@reosarevok reosarevok added the React PRs directly related with React conversion label May 10, 2020
reosarevok
reosarevok approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is fine :)

mwiencek
mwiencek requested changes May 21, 2020
View reviewed changes
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort name field is missing when compared to the old template. That's historical data which I think we should still show for old edits.

mwiencek
mwiencek requested changes May 21, 2020
View reviewed changes
root/edit/details/AddLabel.js Outdated Show resolved Hide resolved
@reosarevok
Copy link
Member

Oh, duh, missed the sort name. Yes, we definitely should still show that when present :)

@reosarevok
Copy link
Member

Adapted this to types-first, added missing sortname field, fixed comment type issue. @yvanzo, @mwiencek: maybe we can merge this now :)

yvanzo
yvanzo approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvanzo yvanzo requested a review from mwiencek June 4, 2020 08:36
@mwiencek
Copy link
Member

This looked good except deleted labels were shown as being added. I copied the change from 20cb5c0 to this file, which fixed that. Also rebased on master.

@mwiencek mwiencek merged commit eb24d73 into metabrainz:master Jun 30, 2020
yvanzo added a commit that referenced this pull request Aug 3, 2020
@yvanzo
Merge branch 'master' into beta
be50d29 
* master:
  Update POT files using the production database
  Update translations from Transifex
  MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572)
  MBS-10949 (2/2): Add Migu Music URL to the sidebar
  MBS-10949 (1/2): Handle Migu Music URLs
  MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614)
  MBS-10980: Convert Remove Entity edit to React (#1606)
  MBS-10983: Convert Remove Release Label edit to React (#1609)
  MBS-10193: Support Apple Music and Apple Books (#1597)
  MBS-10974: Convert Remove ISRC edit to React (#1604)
  MBS-10975: Convert Remove ISWC edit to React (#1605)
  MBS-10969: Convert Add ISRCs edit to React (#1600)
  MBS-10970: Convert Add Release Label edit to React (#1601)
  MBS-10968: Convert Add ISWCs edit to React (#1599)
  Install bzip2 in the test-database docker image (#1621)
  MBS-8725: Allow mediums to have an unknown tracklist (#1103)
  Skip looking for latest vote when not logged in (#1607)
  MBS-10923: Fix inconsistent ordering in find_by_collection (#1591)
  Bump lodash version to 4.17.19
  Bump react-table version to 7.3.2
  Fix warning when displaying Add rel. attr. edit
  MBS-10926: Add 'copy date' button on relationship editor dialog (#1583)
  Strengthen the validation of Instagram URLs
  Refactor: Simplify cleanup regexp for Instagram
  MBS-10932: Match Instagram videos /p/ and /tv/
  Fix handling of js tape object serialization
  MBS-10973: Convert Add Relationship Attribute edit to React
  MBS-10930: Fix loading relationship entities for removed reltypes (#1589)
  MBS-10943: Fix loading attribute on Relationship::Delete (#1594)
  Avoid warnings in Entity::Relationship
  MBS-10833: Avoid crashing if entity0_id is missing
  MBS-10917: Remove no longer used "attendance" (#1579)
  MBS-10927: Check whether entity existed before setting allowNew (#1584)
  MBS-10937: Run load_meta on event lists for ratings (#1587)
  Improve upon MBS-9502 with list of releases
  Move help messages about barcode together in the release editor
  MBS-9502: Add search for pre-existing barcode value in release editor
  Bump Flow to 0.129.0
  Fix some left-behind "import React" imports (#1580)
  MBS-10928: Update the VGMdb favicon
  MBS-10925: Update the Baidu Baike favicon
  MBS-10816: Convert Add Label Edit to React (#1506)
  Bump react-table version to 7.2.1 (#1576)
  Add context to translation strings
  MBS-10562: Add phrases for future (sidebar) dates
yvanzo added a commit that referenced this pull request Aug 10, 2020
@yvanzo
Merge branch 'beta' into production
daeabfd 
* beta:
  Drop autoselect for Apple Music (#1643)
  Update translations from Transifex
  Revert "MBS-8725: Allow mediums to have an unknown tracklist (#1103)"
  Update POT files using the production database
  Update translations from Transifex
  MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572)
  MBS-10949 (2/2): Add Migu Music URL to the sidebar
  MBS-10949 (1/2): Handle Migu Music URLs
  MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614)
  MBS-10980: Convert Remove Entity edit to React (#1606)
  MBS-10983: Convert Remove Release Label edit to React (#1609)
  MBS-10193: Support Apple Music and Apple Books (#1597)
  MBS-10974: Convert Remove ISRC edit to React (#1604)
  MBS-10975: Convert Remove ISWC edit to React (#1605)
  MBS-10969: Convert Add ISRCs edit to React (#1600)
  MBS-10970: Convert Add Release Label edit to React (#1601)
  MBS-10968: Convert Add ISWCs edit to React (#1599)
  Install bzip2 in the test-database docker image (#1621)
  MBS-8725: Allow mediums to have an unknown tracklist (#1103)
  Skip looking for latest vote when not logged in (#1607)
  MBS-10923: Fix inconsistent ordering in find_by_collection (#1591)
  Bump lodash version to 4.17.19
  Bump react-table version to 7.3.2
  Fix warning when displaying Add rel. attr. edit
  MBS-10926: Add 'copy date' button on relationship editor dialog (#1583)
  Strengthen the validation of Instagram URLs
  Refactor: Simplify cleanup regexp for Instagram
  MBS-10932: Match Instagram videos /p/ and /tv/
  Fix handling of js tape object serialization
  MBS-10973: Convert Add Relationship Attribute edit to React
  MBS-10930: Fix loading relationship entities for removed reltypes (#1589)
  MBS-10943: Fix loading attribute on Relationship::Delete (#1594)
  Avoid warnings in Entity::Relationship
  MBS-10833: Avoid crashing if entity0_id is missing
  MBS-10917: Remove no longer used "attendance" (#1579)
  MBS-10927: Check whether entity existed before setting allowNew (#1584)
  MBS-10937: Run load_meta on event lists for ratings (#1587)
  Improve upon MBS-9502 with list of releases
  Move help messages about barcode together in the release editor
  MBS-9502: Add search for pre-existing barcode value in release editor
  Bump Flow to 0.129.0
  Fix some left-behind "import React" imports (#1580)
  MBS-10928: Update the VGMdb favicon
  MBS-10925: Update the Baidu Baike favicon
  MBS-10816: Convert Add Label Edit to React (#1506)
  Bump react-table version to 7.2.1 (#1576)
  Add context to translation strings
  MBS-10562: Add phrases for future (sidebar) dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek approved these changes

@reosarevok reosarevok reosarevok approved these changes

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
React PRs directly related with React conversion
Projects
None yet
Milestone
No milestone
4 participants
@anirudhjain75 @reosarevok @mwiencek @yvanzo