Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10926: add 'copy date' button on relationship editor dialog #1583

Merged
merged 1 commit into from
Jul 22, 2020
Merged

MBS-10926: add 'copy date' button on relationship editor dialog #1583

merged 1 commit into from
Jul 22, 2020

Conversation

loujine
Copy link
Contributor

@loujine loujine commented Jul 1, 2020

Problem

MBS-10926: Add "paste date" button in relationship editor dialogs

Solution

Minimal solution to keep the UI simple:

  • only the copy begin → end behavior
  • only on the relationship editor

The userscript still exists for more complex behavior.
I guess this part will be converted to React later, so it might be easy to apply somewhere else.

Checklist for author

Looks ready to me

@loujine loujine force-pushed the MBS-10926-paste_dates_in_relationship_editor branch from 2c6a9de to f5b9ebf Compare July 1, 2020 23:36
@loujine loujine changed the title MBS-9500: add 'copy date' button on relationship editor dialog MBS-10926: add 'copy date' button on relationship editor dialog Jul 2, 2020
reosarevok
reosarevok approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work fine, although the icon kinda suggests to me that it will copy the date to my storage or something - maybe something with arrows pointing down would make it more clear?

@loujine
Copy link
Contributor Author

loujine commented Jul 13, 2020

I will try to find a clearer icon.
I thought also about using some kind of chain/link icon (like https://daviesmediadesign.com/wp-content/uploads/2019/05/Final-Image-Resolution-Resize-Image-in-GIMP-Tutorial.jpg) but it doesn't really correspond to the button behavior

yvanzo
yvanzo requested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the icon, I would suggest:

  • either to use a simple ⬇️ on the right of the Begin date field (current position),
  • or to use the magnet icon (already used in account preferences) on the right of the End date field (and then to change the title to “Copy from begin date”).

@loujine
MBS-10926: Add 'copy date' button on relationship editor dialog
c7d0e71 
Add a button to copy quickly the "begin date" content to the "end date"
fields. Since the dates fields are implemented differently in different
parts of MusicBrainz, this solution works only on the Relationship
Editor, which is probably where this functionality is most needed.

The button will be displayed on the same line as and after the begin
date fields, which makes the most sense for a keyboard workflow (Tab key
between begin date fields, then Tab Enter to copy or Tab Tab to access
the end date fields).
@loujine loujine force-pushed the MBS-10926-paste_dates_in_relationship_editor branch from f5b9ebf to c7d0e71 Compare July 21, 2020 15:07
@loujine
Copy link
Contributor Author

loujine commented Jul 21, 2020

  • added localization
  • changed icon to the down arrow already in images/icons/down.png
  • tried to improve the commit message :)

@yvanzo: for me having the icon on the begin date line makes more sense, since I use my Tab key to jump between begin fields then tab/enter to copy to the end dates. But I don't have a strong feeling for UX in general, so I'll change it if you think it's better

yvanzo
yvanzo approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@yvanzo yvanzo merged commit c81af39 into metabrainz:master Jul 22, 2020
reosarevok pushed a commit to reosarevok/musicbrainz-server that referenced this pull request Jul 24, 2020
@loujine @reosarevok
MBS-10926: Add 'copy date' button on relationship editor dialog (meta…
6cbb4d3 
…brainz#1583)

Add a button to copy quickly the "begin date" content to the "end date"
fields. Since the dates fields are implemented differently in different
parts of MusicBrainz, this solution works only on the Relationship
Editor, which is probably where this functionality is most needed.

The button will be displayed on the same line as and after the begin
date fields, which makes the most sense for a keyboard workflow (Tab key
between begin date fields, then Tab Enter to copy or Tab Tab to access
the end date fields).
yvanzo added a commit that referenced this pull request Aug 3, 2020
@yvanzo
Merge branch 'master' into beta
be50d29 
* master:
  Update POT files using the production database
  Update translations from Transifex
  MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572)
  MBS-10949 (2/2): Add Migu Music URL to the sidebar
  MBS-10949 (1/2): Handle Migu Music URLs
  MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614)
  MBS-10980: Convert Remove Entity edit to React (#1606)
  MBS-10983: Convert Remove Release Label edit to React (#1609)
  MBS-10193: Support Apple Music and Apple Books (#1597)
  MBS-10974: Convert Remove ISRC edit to React (#1604)
  MBS-10975: Convert Remove ISWC edit to React (#1605)
  MBS-10969: Convert Add ISRCs edit to React (#1600)
  MBS-10970: Convert Add Release Label edit to React (#1601)
  MBS-10968: Convert Add ISWCs edit to React (#1599)
  Install bzip2 in the test-database docker image (#1621)
  MBS-8725: Allow mediums to have an unknown tracklist (#1103)
  Skip looking for latest vote when not logged in (#1607)
  MBS-10923: Fix inconsistent ordering in find_by_collection (#1591)
  Bump lodash version to 4.17.19
  Bump react-table version to 7.3.2
  Fix warning when displaying Add rel. attr. edit
  MBS-10926: Add 'copy date' button on relationship editor dialog (#1583)
  Strengthen the validation of Instagram URLs
  Refactor: Simplify cleanup regexp for Instagram
  MBS-10932: Match Instagram videos /p/ and /tv/
  Fix handling of js tape object serialization
  MBS-10973: Convert Add Relationship Attribute edit to React
  MBS-10930: Fix loading relationship entities for removed reltypes (#1589)
  MBS-10943: Fix loading attribute on Relationship::Delete (#1594)
  Avoid warnings in Entity::Relationship
  MBS-10833: Avoid crashing if entity0_id is missing
  MBS-10917: Remove no longer used "attendance" (#1579)
  MBS-10927: Check whether entity existed before setting allowNew (#1584)
  MBS-10937: Run load_meta on event lists for ratings (#1587)
  Improve upon MBS-9502 with list of releases
  Move help messages about barcode together in the release editor
  MBS-9502: Add search for pre-existing barcode value in release editor
  Bump Flow to 0.129.0
  Fix some left-behind "import React" imports (#1580)
  MBS-10928: Update the VGMdb favicon
  MBS-10925: Update the Baidu Baike favicon
  MBS-10816: Convert Add Label Edit to React (#1506)
  Bump react-table version to 7.2.1 (#1576)
  Add context to translation strings
  MBS-10562: Add phrases for future (sidebar) dates
@loujine loujine deleted the MBS-10926-paste_dates_in_relationship_editor branch August 9, 2020 23:28
yvanzo added a commit that referenced this pull request Aug 10, 2020
@yvanzo
Merge branch 'beta' into production
daeabfd 
* beta:
  Drop autoselect for Apple Music (#1643)
  Update translations from Transifex
  Revert "MBS-8725: Allow mediums to have an unknown tracklist (#1103)"
  Update POT files using the production database
  Update translations from Transifex
  MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572)
  MBS-10949 (2/2): Add Migu Music URL to the sidebar
  MBS-10949 (1/2): Handle Migu Music URLs
  MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614)
  MBS-10980: Convert Remove Entity edit to React (#1606)
  MBS-10983: Convert Remove Release Label edit to React (#1609)
  MBS-10193: Support Apple Music and Apple Books (#1597)
  MBS-10974: Convert Remove ISRC edit to React (#1604)
  MBS-10975: Convert Remove ISWC edit to React (#1605)
  MBS-10969: Convert Add ISRCs edit to React (#1600)
  MBS-10970: Convert Add Release Label edit to React (#1601)
  MBS-10968: Convert Add ISWCs edit to React (#1599)
  Install bzip2 in the test-database docker image (#1621)
  MBS-8725: Allow mediums to have an unknown tracklist (#1103)
  Skip looking for latest vote when not logged in (#1607)
  MBS-10923: Fix inconsistent ordering in find_by_collection (#1591)
  Bump lodash version to 4.17.19
  Bump react-table version to 7.3.2
  Fix warning when displaying Add rel. attr. edit
  MBS-10926: Add 'copy date' button on relationship editor dialog (#1583)
  Strengthen the validation of Instagram URLs
  Refactor: Simplify cleanup regexp for Instagram
  MBS-10932: Match Instagram videos /p/ and /tv/
  Fix handling of js tape object serialization
  MBS-10973: Convert Add Relationship Attribute edit to React
  MBS-10930: Fix loading relationship entities for removed reltypes (#1589)
  MBS-10943: Fix loading attribute on Relationship::Delete (#1594)
  Avoid warnings in Entity::Relationship
  MBS-10833: Avoid crashing if entity0_id is missing
  MBS-10917: Remove no longer used "attendance" (#1579)
  MBS-10927: Check whether entity existed before setting allowNew (#1584)
  MBS-10937: Run load_meta on event lists for ratings (#1587)
  Improve upon MBS-9502 with list of releases
  Move help messages about barcode together in the release editor
  MBS-9502: Add search for pre-existing barcode value in release editor
  Bump Flow to 0.129.0
  Fix some left-behind "import React" imports (#1580)
  MBS-10928: Update the VGMdb favicon
  MBS-10925: Update the Baidu Baike favicon
  MBS-10816: Convert Add Label Edit to React (#1506)
  Bump react-table version to 7.2.1 (#1576)
  Add context to translation strings
  MBS-10562: Add phrases for future (sidebar) dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek left review comments

@reosarevok reosarevok reosarevok approved these changes

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@loujine @mwiencek @reosarevok @yvanzo