MBS-10943: Fix loading attribute on Relationship::Delete #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always creating a new LinkAttributeType means we're missing data that is necessary, for example, to decide whether to also convert text_value to JSON, causing the bug here. This change ensures that we use the actual attribute as loaded from the DB if possible, in the same way we already do on Relationship::Create.
yvanzo
approved these changes
Jul 16, 2020
mwiencek
approved these changes
Jul 16, 2020
yvanzo
added a commit
that referenced
this pull request
Aug 3, 2020
* master: Update POT files using the production database Update translations from Transifex MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572) MBS-10949 (2/2): Add Migu Music URL to the sidebar MBS-10949 (1/2): Handle Migu Music URLs MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614) MBS-10980: Convert Remove Entity edit to React (#1606) MBS-10983: Convert Remove Release Label edit to React (#1609) MBS-10193: Support Apple Music and Apple Books (#1597) MBS-10974: Convert Remove ISRC edit to React (#1604) MBS-10975: Convert Remove ISWC edit to React (#1605) MBS-10969: Convert Add ISRCs edit to React (#1600) MBS-10970: Convert Add Release Label edit to React (#1601) MBS-10968: Convert Add ISWCs edit to React (#1599) Install bzip2 in the test-database docker image (#1621) MBS-8725: Allow mediums to have an unknown tracklist (#1103) Skip looking for latest vote when not logged in (#1607) MBS-10923: Fix inconsistent ordering in find_by_collection (#1591) Bump lodash version to 4.17.19 Bump react-table version to 7.3.2 Fix warning when displaying Add rel. attr. edit MBS-10926: Add 'copy date' button on relationship editor dialog (#1583) Strengthen the validation of Instagram URLs Refactor: Simplify cleanup regexp for Instagram MBS-10932: Match Instagram videos /p/ and /tv/ Fix handling of js tape object serialization MBS-10973: Convert Add Relationship Attribute edit to React MBS-10930: Fix loading relationship entities for removed reltypes (#1589) MBS-10943: Fix loading attribute on Relationship::Delete (#1594) Avoid warnings in Entity::Relationship MBS-10833: Avoid crashing if entity0_id is missing MBS-10917: Remove no longer used "attendance" (#1579) MBS-10927: Check whether entity existed before setting allowNew (#1584) MBS-10937: Run load_meta on event lists for ratings (#1587) Improve upon MBS-9502 with list of releases Move help messages about barcode together in the release editor MBS-9502: Add search for pre-existing barcode value in release editor Bump Flow to 0.129.0 Fix some left-behind "import React" imports (#1580) MBS-10928: Update the VGMdb favicon MBS-10925: Update the Baidu Baike favicon MBS-10816: Convert Add Label Edit to React (#1506) Bump react-table version to 7.2.1 (#1576) Add context to translation strings MBS-10562: Add phrases for future (sidebar) dates
yvanzo
added a commit
that referenced
this pull request
Aug 10, 2020
* beta: Drop autoselect for Apple Music (#1643) Update translations from Transifex Revert "MBS-8725: Allow mediums to have an unknown tracklist (#1103)" Update POT files using the production database Update translations from Transifex MBS-7994 / MBS-10746: Add pregap icon and indicate pregap in edits (#1572) MBS-10949 (2/2): Add Migu Music URL to the sidebar MBS-10949 (1/2): Handle Migu Music URLs MBS-10989: Update VocaDB cleanup to support new Es (series) format (#1614) MBS-10980: Convert Remove Entity edit to React (#1606) MBS-10983: Convert Remove Release Label edit to React (#1609) MBS-10193: Support Apple Music and Apple Books (#1597) MBS-10974: Convert Remove ISRC edit to React (#1604) MBS-10975: Convert Remove ISWC edit to React (#1605) MBS-10969: Convert Add ISRCs edit to React (#1600) MBS-10970: Convert Add Release Label edit to React (#1601) MBS-10968: Convert Add ISWCs edit to React (#1599) Install bzip2 in the test-database docker image (#1621) MBS-8725: Allow mediums to have an unknown tracklist (#1103) Skip looking for latest vote when not logged in (#1607) MBS-10923: Fix inconsistent ordering in find_by_collection (#1591) Bump lodash version to 4.17.19 Bump react-table version to 7.3.2 Fix warning when displaying Add rel. attr. edit MBS-10926: Add 'copy date' button on relationship editor dialog (#1583) Strengthen the validation of Instagram URLs Refactor: Simplify cleanup regexp for Instagram MBS-10932: Match Instagram videos /p/ and /tv/ Fix handling of js tape object serialization MBS-10973: Convert Add Relationship Attribute edit to React MBS-10930: Fix loading relationship entities for removed reltypes (#1589) MBS-10943: Fix loading attribute on Relationship::Delete (#1594) Avoid warnings in Entity::Relationship MBS-10833: Avoid crashing if entity0_id is missing MBS-10917: Remove no longer used "attendance" (#1579) MBS-10927: Check whether entity existed before setting allowNew (#1584) MBS-10937: Run load_meta on event lists for ratings (#1587) Improve upon MBS-9502 with list of releases Move help messages about barcode together in the release editor MBS-9502: Add search for pre-existing barcode value in release editor Bump Flow to 0.129.0 Fix some left-behind "import React" imports (#1580) MBS-10928: Update the VGMdb favicon MBS-10925: Update the Baidu Baike favicon MBS-10816: Convert Add Label Edit to React (#1506) Bump react-table version to 7.2.1 (#1576) Add context to translation strings MBS-10562: Add phrases for future (sidebar) dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-10943
Always creating a new LinkAttributeType means we're missing data that is necessary, for example, to decide whether to also convert text_value to JSON, causing the bug here. This change ensures that we use the actual attribute as loaded from the DB if possible, in the same way we already do on Relationship::Create.