Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node renderer fixes #510

Merged
merged 5 commits into from May 29, 2017
Merged

Node renderer fixes #510

merged 5 commits into from May 29, 2017

Commits on May 17, 2017

  1. Update node-raven to 2.0 

    Version 2.0 has better error logging (doesn't obscure uncaught
exceptions).

The install() line had to be moved because Raven.wrap now throws an
exception if Raven isn't configured yet.
    @mwiencek
    mwiencek committed May 17, 2017
    Copy the full SHA
    4653855 View commit details
    Browse the repository at this point in the history

  2. Replace use of String.prototype.includes 

    Use RegExp.prototype.test, which is supported in older versions of node.
    @mwiencek
    mwiencek committed May 17, 2017
    Copy the full SHA
    1680364 View commit details
    Browse the repository at this point in the history

  3. Fall back to old Buffer API

    @mwiencek
    mwiencek committed May 17, 2017
    Copy the full SHA
    43a385d View commit details
    Browse the repository at this point in the history

  4. Raven.wrap some additional functions 

    Even though killNext and receiveData are inside functions which are
already wrapped, they're executed in different stack frames, so they
also needs to be wrapped.
    @mwiencek
    mwiencek committed May 17, 2017
    Copy the full SHA
    0d04c56 View commit details
    Browse the repository at this point in the history

  5. Use _.values instead of Object.values 

    Object.values is unavailable in older versions of Node.

Object.keys should be fine, but I've replaced it too for consistency.
    @mwiencek
    mwiencek committed May 17, 2017
    Copy the full SHA
    73ae08b View commit details
    Browse the repository at this point in the history