Let the user configure unicode & error syntax highlight colors

metabrainz · May 26, 2024 · 4acf120 · 4acf120
1 parent dfc1ea9
commit 4acf120
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/picard/ui/colors.py b/picard/ui/colors.py
@@ -52,11 +52,13 @@ class UnknownColorException(Exception):
     'tagstatus_added': N_("Tag added"),
     'tagstatus_changed': N_("Tag changed"),
     'tagstatus_removed': N_("Tag removed"),
-    'syntax_hl_func': N_("Function syntax highlight"),
-    'syntax_hl_var': N_("Variable syntax highlight"),
+    'syntax_hl_error': N_("Error syntax highlight"),
     'syntax_hl_escape': N_("Escape syntax highlight"),
-    'syntax_hl_special': N_("Special syntax highlight"),
+    'syntax_hl_func': N_("Function syntax highlight"),
     'syntax_hl_noop': N_("Noop syntax highlight"),
+    'syntax_hl_special': N_("Special syntax highlight"),
+    'syntax_hl_unicode': N_("Unicode syntax highlight"),
+    'syntax_hl_var': N_("Variable syntax highlight"),
 }
 
 
@@ -103,16 +105,20 @@ def register_color(themes, name, value):
 register_color(_DARK, 'first_cover_hl', 'orange')
 
 # syntax highlighting colors
-register_color(_LIGHT, 'syntax_hl_func', 'blue'),
-register_color(_LIGHT, 'syntax_hl_var', 'darkCyan'),
+register_color(_LIGHT, 'syntax_hl_error', 'blue'),
 register_color(_LIGHT, 'syntax_hl_escape', 'darkRed'),
-register_color(_LIGHT, 'syntax_hl_special', 'blue'),
+register_color(_LIGHT, 'syntax_hl_func', 'blue'),
 register_color(_LIGHT, 'syntax_hl_noop', 'darkGray'),
-register_color(_DARK, 'syntax_hl_func', '#FF57A0'),
-register_color(_DARK, 'syntax_hl_var', '#FCBB51'),
+register_color(_LIGHT, 'syntax_hl_special', 'blue'),
+register_color(_LIGHT, 'syntax_hl_unicode', 'darkRed'),
+register_color(_LIGHT, 'syntax_hl_var', 'darkCyan'),
+register_color(_DARK, 'syntax_hl_error', '#FF57A0'),
 register_color(_DARK, 'syntax_hl_escape', '#4BEF1F'),
-register_color(_DARK, 'syntax_hl_special', '#FF57A0'),
+register_color(_DARK, 'syntax_hl_func', '#FF57A0'),
 register_color(_DARK, 'syntax_hl_noop', '#04E7D5'),
+register_color(_DARK, 'syntax_hl_special', '#FF57A0'),
+register_color(_DARK, 'syntax_hl_unicode', '#4BEF1F'),
+register_color(_DARK, 'syntax_hl_var', '#FCBB51'),
 
 
 class InterfaceColors:

diff --git a/picard/ui/widgets/scripttextedit.py b/picard/ui/widgets/scripttextedit.py
@@ -132,7 +132,7 @@ def __init__(self, document):
             'noop': HighlightFormat(fg_color='syntax_hl_noop', bold=True, italic=True),
             'special': HighlightFormat(fg_color='syntax_hl_special'),
             'unicode': HighlightFormat(fg_color='syntax_hl_escape', italic=True),
-            'unknown_func': HighlightFormat(fg_color='syntax_hl_special', italic=True),
+            'unknown_func': HighlightFormat(fg_color='syntax_hl_error', italic=True),
             'var': HighlightFormat(fg_color='syntax_hl_var'),
         }