Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle preserve state #2478

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Toggle preserve state #2478

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
911f1ac
Toggle one or more tags preserve state at once
zas May 17, 2024
faaf45b
Add internal tag name as tooltip to tag column items
zas May 18, 2024
83aa8db
preserved -> is_preserved
zas May 18, 2024
b481b96
Reduce code redundancy
zas May 18, 2024
ef939ff
If a tag is marked as preserved, disable modify/remove actions
zas May 18, 2024
861419e
Revamp code a bit
zas May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 46 additions & 19 deletions picard/ui/metadatabox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@
)


def bit_not(num):
"""Bitwise not, unsigned"""
return num ^ ((1 << num.bit_length()) - 1)


class TagStatus:
NONE = 0
NOCHANGE = 1
Expand Down Expand Up @@ -185,6 +190,12 @@ def tag_status(self, tag):
return s
return TagStatus.NOCHANGE

def set_bits(self, tag, bits):
self.status[tag] |= bits

def unset_bits(self, tag, bits):
self.status[tag] &= bit_not(bits)


class TableTagEditorDelegate(TagEditorDelegate):

Expand Down Expand Up @@ -385,16 +396,6 @@ def contextMenuEvent(self, event):
edit_tag_action.setShortcut(self.edit_tag_shortcut.key())
edit_tag_action.setEnabled(editable)
menu.addAction(edit_tag_action)
if selected_tag not in self.preserved_tags:
add_to_preserved_tags_action = QtGui.QAction(_("Add to 'Preserve Tags' List"), self)
add_to_preserved_tags_action.triggered.connect(partial(self.preserved_tags.add, selected_tag))
add_to_preserved_tags_action.setEnabled(editable)
menu.addAction(add_to_preserved_tags_action)
else:
remove_from_preserved_tags_action = QtGui.QAction(_("Remove from 'Preserve Tags' List"), self)
remove_from_preserved_tags_action.triggered.connect(partial(self.preserved_tags.discard, selected_tag))
remove_from_preserved_tags_action.setEnabled(editable)
menu.addAction(remove_from_preserved_tags_action)
removals = []
useorigs = []
item = self.currentItem()
Expand Down Expand Up @@ -438,6 +439,11 @@ def contextMenuEvent(self, event):
remove_tag_action.setShortcut(self.remove_tag_shortcut.key())
remove_tag_action.setEnabled(bool(removals))
menu.addAction(remove_tag_action)

add_to_preserved_tags_action = QtGui.QAction(_("Toggle Preserve state"), self)
add_to_preserved_tags_action.triggered.connect(self._toggle_preserved)
menu.addAction(add_to_preserved_tags_action)

if useorigs:
name = ngettext("Use Original Value", "Use Original Values", len(useorigs))
use_orig_value_action = QtGui.QAction(name, self)
Expand Down Expand Up @@ -478,6 +484,14 @@ def _edit_selected_tag(self):
if len(tags) == 1:
self._edit_tag(tags[0])

def _toggle_preserved(self):
for tag in self._selected_tags(filter_func=lambda t: t != '~length'):
if tag in self.preserved_tags:
self.preserved_tags.discard(tag)
else:
self.preserved_tags.add(tag)
self.update()

def _toggle_changes_first(self, checked):
config = get_config()
config.persist['show_changes_first'] = checked
Expand Down Expand Up @@ -678,19 +692,33 @@ def _update_items(self, result=None, error=None):
alignment = QtCore.Qt.AlignmentFlag.AlignLeft | QtCore.Qt.AlignmentFlag.AlignTop

for i, tag in enumerate(self.tag_diff.tag_names):
is_preserved = tag in self.preserved_tags
if tag == '~length' or is_preserved:
self.tag_diff.set_bits(tag, TagStatus.NOTREMOVABLE | TagStatus.READONLY)
new_item_flags = orig_flags
elif tag != '~length':
self.tag_diff.unset_bits(tag, TagStatus.NOTREMOVABLE | TagStatus.READONLY)
new_item_flags = new_flags

color = self.colors.get(self.tag_diff.tag_status(tag),
self.colors[TagStatus.NOCHANGE])

tag_item = self.item(i, self.COLUMN_TAG)
if not tag_item:
tag_item = QtWidgets.QTableWidgetItem()
tag_item.setFlags(orig_flags)
font = tag_item.font()
font.setBold(True)
tag_item.setFont(font)
tag_item.setTextAlignment(alignment)
tag_item.setToolTip(tag)
self.setItem(i, self.COLUMN_TAG, tag_item)
tag_item.setText(display_tag_name(tag))
text = display_tag_name(tag)
is_preserved = tag in self.preserved_tags
font = tag_item.font()
font.setBold(not is_preserved)
tag_item.setFont(font)
if is_preserved:
preserved_indicator_fmt = _('%s [P]')
text = preserved_indicator_fmt % text
tag_item.setText(text)

orig_item = self.item(i, self.COLUMN_ORIG)
if not orig_item:
Expand All @@ -705,16 +733,15 @@ def _update_items(self, result=None, error=None):
if not new_item:
new_item = QtWidgets.QTableWidgetItem()
new_item.setTextAlignment(alignment)
if tag == '~length':
new_item.setFlags(orig_flags)
else:
new_item.setFlags(new_flags)
self.setItem(i, self.COLUMN_NEW, new_item)
self._set_item_value(new_item, self.tag_diff.new, tag)
new_item.setFlags(new_item_flags)

font = new_item.font()
strikeout = self.tag_diff.tag_status(tag) == TagStatus.REMOVED
font.setStrikeOut(strikeout)
new_item.setFont(font)

self._set_item_value(new_item, self.tag_diff.new, tag)
new_item.setForeground(color)

# Adjust row height to content size
Expand Down
Loading