PICARD-817, PICARD-960: Port Picard to Qt5(Continued) #503

sambhav · 2016-12-21T22:01:34Z

Continues and finishes #385

mwiencek · 2016-12-22T02:23:15Z

I think the commits should be named "Port Picard to Qt5" and "Port Picard to Qt5 (continued)", where the commit message for the second commit explains that it's a continuation of e41fb3d.

mwiencek · 2016-12-22T02:24:51Z

picard/config.py

-        # XXX QPyNullVariant does not exist in all PyQt versions, and was
-        # removed entirely in PyQt5. See:
-        # http://pyqt.sourceforge.net/Docs/PyQt5/pyqt_qvariant.html
-        if str(type(value)) == "<class 'PyQt4.QtCore.QPyNullVariant'>":


If someone had such a value in their configuration and upgraded Picard, what would str(type(value)) return? We should figure that out.

http://pyqt.sourceforge.net/Docs/PyQt5/pyqt_qvariant.html

According to this it will just convert it to a python object. So I suppose it will just return a str type?

mwiencek · 2016-12-22T02:33:33Z

picard/ui/ui_infodialog.py

-except AttributeError:
-    _fromUtf8 = lambda s: s
-
-class ArtworkTable(QtGui.QTableWidget):


Huh, this shouldn't be removed. Are you sure you rebased things against latest master?

Ah, the file was edited manually in 7451602 (not good). So we'll have to move the custom code to somewhere else, without changing any behavior.

sambhav · 2017-02-10T12:13:09Z

Updated the Qt5 port. (All of picard till 1.4 is ported now) Although all of my commits got merged into @mwiencek 's original commit while rebasing.

mineo · 2017-02-11T11:11:56Z

At the moment, the settings can't be opened:

Traceback (most recent call last):
  File "./picard/ui/mainwindow.py", line 746, in show_options
    dialog = OptionsDialog(page, self)
  File "./picard/ui/options/dialog.py", line 121, in __init__
    page.load()
  File "./picard/ui/options/scripting.py", line 402, in load
    self.ui.script_list.setItemSelected(last_selected_script, True)
AttributeError: 'QListWidget' object has no attribute 'setItemSelected'

mineo · 2017-02-12T16:13:01Z

picard/webservice.py

@@ -512,7 +512,7 @@ def browse_releases(self, handler, priority=True, important=True, **kwargs):
    def submit_ratings(self, ratings, handler):
        host = config.setting['server_host']
        port = config.setting['server_port']
-        path = '/ws/2/rating/'
+        path = '/ws/2/rating/?client=' + CLIENT_STRING


See 2113a13, this is not correct.

I did correct it. No idea why it didn't update O.o.

mineo · 2017-02-12T16:59:15Z

We should probably decide which minimum version of (Py)Qt5 we want to require. Most of the HighDPI things seem to require Qt 5.6 (or at a minimum 5.4), redirection (I think this came up somewhere recently, but don't remember where) support in QNetworkAccessManager is 5.6+ as well.

Freso · 2017-02-13T01:33:56Z

We should probably decide which minimum version of (Py)Qt5 we want to require.

Given the amount of things we want to change, Picard 2.0 probably won't be out for a while yet, so my vote is for not putting the bar on a too old version. 5.6, or even 5.7, would get my vote. (Qt 5.8 was released in January, so PyQt 5.8 will likely get released soon. While I would be happy to go for this version as well, that might be a tad too recent for even non-Debian systems. :))

zas · 2017-02-13T09:51:01Z

Given the amount of things we want to change, Picard 2.0 probably won't be out for a while yet, so my vote is for not putting the bar on a too old version. 5.6, or even 5.7, would get my vote. (Qt 5.8 was released in January, so PyQt 5.8 will likely get released soon. While I would be happy to go for this version as well, that might be a tad too recent for even non-Debian systems. :))

Qt5.4 is the first version with HiDPI support, but it was greatly reworked in 5.6. But 5.6 was released in March 2016, it is a LTS version. 5.4 supports for HiDPI was implemented differently, it was released back 2014. Ubuntu 16.04 comes with Qt 5.5.
So i think we should target the lowest version for now, perhaps adding tests for more recent versions (especially because HiDPI-related features are quite different among 5.x versions).
It also means we can't use 5.6+-only features for now.

Sophist-UK · 2017-02-13T13:54:26Z

Sounds to me like we should go with 5.6.

sambhav · 2017-02-13T13:56:03Z

Ditto with 5.6 given the above points in its favor.

Freso · 2017-02-13T15:31:27Z

Ubuntu 16.04

If people with old Ubuntu's want to run Picard, Picard 1.4.x should continue to work fine for them for some time to come. What does Ubuntu 16.10 ship? Or what will Ubuntu 17.04 and 17.10 have? I doubt Picard 2.0 will be out before October, so non-hardcore-LTS'ers should be able to have switched to a Ubuntu version with a more recent version.

Also, this is one of the reasons I really dislike non-rolling release distros: they hamper software development. Let's not let the "most outdated denominator" determine what library to use, esp. if it means more work 6–12+ months from now. If @samj1912 suddenly gets caught up with something (e.g., paid work, studies, …), then we can wait 2+ years for someone else to pick up the mantle and move us onwards from (Py)Qt 5.4. Let's try and not stay too far behind the curve, please?

(See also: The GoPHP5 mission.)

mineo · 2017-02-17T23:10:11Z

Trying to use the OAuth authentication only gets me

Traceback (most recent call last):
  File "./picard/ui/options/general.py", line 91, in login
    authorization_code, scopes, self.on_authorization_finished)
  File "./picard/oauth.py", line 138, in exchange_authorization_code
    url.setEncodedQuery(url_query)
AttributeError: 'QUrl' object has no attribute 'setEncodedQuery'
zsh: abort (core dumped)  python2 tagger.py

sambhav · 2017-02-20T21:39:32Z

@mineo fixed :)

zas · 2017-03-26T15:14:03Z

Dockerfile

-RUN python setup.py build_locales -i										
-CMD python setup.py test
+RUN python setup.py build_ext -i 
+RUN python setup.py build_locales -i 


Still extra whitespace at end of line (it was worse before though).

zas · 2017-03-26T15:16:15Z

picard/ui/coverartbox.py

@@ -63,17 +63,22 @@ def mouseReleaseEvent(self, event):
            self.clicked.emit()

    def dragEnterEvent(self, event):
-        for url in event.mimeData().urls():
-            if url.scheme() in ('https', 'http', 'file'):


Test about scheme is gone ?

yeah, it is checked again in dropEvent.

Yep, just noticed. Thanks.

zas · 2017-03-26T15:19:12Z

picard/ui/infodialog.py

@@ -297,7 +297,7 @@ def _display_info_tab(self):
        if album.errors:
            tabWidget.setTabText(tab_index, _("&Errors"))
            text = '<br />'.join(map(lambda s: '<font color="darkred">%s</font>' %
-                                     '<br />'.join(unicode(QtCore.Qt.escape(s))
+                                     '<br />'.join(unicode(cgi.escape(s))


I propose to create picard.util.htmlescape() so we can change it to whatever fits the best.

antlarr · 2017-03-27T09:21:20Z

picard/ui/coverartbox.py

-    def fetch_remote_image(self, url):
-        return self.parent().fetch_remote_image(url)
+    def fetch_remote_image(self, url, dropped_data):
+        return self.parent().fetch_remote_image(url, dropped_data)



Reviewing this I noticed a problem in master, so I created #665 . Can you review that PR and make the corresponding rebase here? (note that the PR removes fetch_remote_image from CoverArtThumbnail)

antlarr · 2017-03-27T09:41:03Z

picard/ui/ui_infodialog.py

@@ -67,6 +56,7 @@ def setupUi(self, InfoDialog):
        InfoDialog.setTabOrder(self.tabWidget, self.buttonBox)

    def retranslateUi(self, InfoDialog):
+        _translate = QtCore.QCoreApplication.translate


is _translate used somewhere?

antlarr · 2017-03-27T09:42:43Z

picard/ui/ui_options.py

        self.vboxlayout.addWidget(self.buttonbox)

        self.retranslateUi(Dialog)
        QtCore.QMetaObject.connectSlotsByName(Dialog)

    def retranslateUi(self, Dialog):
+        _translate = QtCore.QCoreApplication.translate


Same here, maybe you wanted to set _ ?

antlarr · 2017-03-27T09:48:18Z

picard/ui/ui_options_advanced.py

        self.vboxlayout.addItem(spacerItem)

        self.retranslateUi(AdvancedOptionsPage)
        QtCore.QMetaObject.connectSlotsByName(AdvancedOptionsPage)

    def retranslateUi(self, AdvancedOptionsPage):
+        _translate = QtCore.QCoreApplication.translate


And also here and all other retranslateUi methods in other classes

antlarr · 2017-03-27T10:02:04Z

picard/ui/ui_options_renaming.py

@@ -173,7 +160,7 @@ def retranslateUi(self, RenamingOptionsPage):
 "<html><head><meta name=\"qrichtext\" content=\"1\" /><style type=\"text/css\">\n"


This line seems to have the only call to _translate in all picard's code (at least from a quick grep I did). Maybe it can be changed to _ and remove the _translate entry from _translate_re in setup.py ?

mwiencek · 2017-04-03T19:02:21Z

You removed my authorship from the initial commit. :(

sambhav · 2017-04-03T19:13:22Z

You removed my authorship from the initial commit. :(

Sorry, it had too many merge conflicts, I had to checkout every file from the current qt5 branch.
Umm, can you rebase the master and fix it?

mwiencek · 2017-04-03T19:25:29Z

It's okay, I don't think it's worth rewriting history. :)

sambhav changed the title ~~Port Picard to PyQt5~~ PICARD-817: Port Picard to PyQt5 Dec 21, 2016

mwiencek reviewed Dec 22, 2016

View reviewed changes

sambhav changed the title ~~PICARD-817: Port Picard to PyQt5~~ PICARD-817: Port Picard to Qt5(Continued) Dec 22, 2016

sambhav force-pushed the qt5 branch 10 times, most recently from 26dfb46 to 15cc4c5 Compare December 27, 2016 20:26

sambhav force-pushed the qt5 branch from 15cc4c5 to ffba201 Compare February 10, 2017 12:06

mineo reviewed Feb 12, 2017

View reviewed changes

sambhav changed the title ~~PICARD-817: Port Picard to Qt5(Continued)~~ PICARD-817, PICARD-960: Port Picard to Qt5(Continued) Feb 12, 2017

sambhav force-pushed the qt5 branch from f54113d to b1c7dfe Compare February 20, 2017 21:39

sambhav force-pushed the qt5 branch from b1c7dfe to 949e1ba Compare February 22, 2017 03:43

sambhav force-pushed the qt5 branch 8 times, most recently from 1ab23ad to 59d717c Compare March 26, 2017 14:17

zas reviewed Mar 26, 2017

View reviewed changes

antlarr reviewed Mar 27, 2017

View reviewed changes

sambhav added 8 commits April 3, 2017 16:45

Port Picard to Qt5

428e168

Port obselete setItemSelected

9b29be2

Fix ws rating call

f8af7a6

Remove obsolete setEncodedQuery method

4f40135

Update Qt5 port

559d5dd

Fix remote image drops in Qt5

4344fed

Introduce picard.util.htmlescape and remove whitespace

591f759

Bump version to 2.0 dev

6285478

sambhav force-pushed the qt5 branch from cb5a735 to 6285478 Compare April 3, 2017 11:18

zas approved these changes Apr 3, 2017

View reviewed changes

zas merged commit 5022d5d into metabrainz:master Apr 3, 2017

sambhav deleted the qt5 branch February 9, 2018 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PICARD-817, PICARD-960: Port Picard to Qt5(Continued) #503

PICARD-817, PICARD-960: Port Picard to Qt5(Continued) #503

sambhav commented Dec 21, 2016 •

edited

Loading

mwiencek commented Dec 22, 2016

mwiencek Dec 22, 2016

sambhav Dec 22, 2016

mwiencek Dec 22, 2016

mwiencek Dec 22, 2016

sambhav commented Feb 10, 2017

mineo commented Feb 11, 2017

mineo Feb 12, 2017

sambhav Feb 12, 2017

mineo commented Feb 12, 2017

Freso commented Feb 13, 2017

zas commented Feb 13, 2017

Sophist-UK commented Feb 13, 2017

sambhav commented Feb 13, 2017

Freso commented Feb 13, 2017

mineo commented Feb 17, 2017

sambhav commented Feb 20, 2017

zas Mar 26, 2017

zas Mar 26, 2017

sambhav Mar 26, 2017

zas Mar 26, 2017

zas Mar 26, 2017

antlarr Mar 27, 2017

antlarr Mar 27, 2017

antlarr Mar 27, 2017

antlarr Mar 27, 2017

antlarr Mar 27, 2017

mwiencek commented Apr 3, 2017

sambhav commented Apr 3, 2017 •

edited

Loading

mwiencek commented Apr 3, 2017

		@@ -173,7 +160,7 @@ def retranslateUi(self, RenamingOptionsPage):
		"<html><head><meta name=\"qrichtext\" content=\"1\" /><style type=\"text/css\">\n"

PICARD-817, PICARD-960: Port Picard to Qt5(Continued) #503

PICARD-817, PICARD-960: Port Picard to Qt5(Continued) #503

Conversation

sambhav commented Dec 21, 2016 • edited Loading

mwiencek commented Dec 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sambhav commented Feb 10, 2017

mineo commented Feb 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mineo commented Feb 12, 2017

Freso commented Feb 13, 2017

zas commented Feb 13, 2017

Sophist-UK commented Feb 13, 2017

sambhav commented Feb 13, 2017

Freso commented Feb 13, 2017

mineo commented Feb 17, 2017

sambhav commented Feb 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mwiencek commented Apr 3, 2017

sambhav commented Apr 3, 2017 • edited Loading

mwiencek commented Apr 3, 2017

sambhav commented Dec 21, 2016 •

edited

Loading

sambhav commented Apr 3, 2017 •

edited

Loading