Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ArtistCredit, cleanup old cruft and use MB recording cache #134

Merged
merged 23 commits into from
Apr 12, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Apr 11, 2024

This rather large PR (sorry!) creates a new ArtistCredit object that should've been created a long time ago. All existing code has now been refactored to use ArtistCredits.

There were several modules no longer in use, for endpoints that no longer existed. Cleaned up.

Finally the recording_lookup now uses the MB Recording Cache, which makes everything faster and merges tag and year lookup into one concise module.

More work will be needed to make a new LB Radio release, but once that is complete, then we'll release Troi 1.0!

@mayhem mayhem requested a review from amCap1712 April 11, 2024 11:59
Copy link

github-actions bot commented Apr 11, 2024

Test Results

  4 files  ± 0    4 suites  ±0   4s ⏱️ ±0s
 51 tests  -  5   51 ✅  -  5  0 💤 ±0  0 ❌ ±0 
204 runs   - 20  204 ✅  - 20  0 💤 ±0  0 ❌ ±0 

Results for commit a5cfedb. ± Comparison against base commit a262451.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
tests.listenbrainz.test_area_random_recordings.TestAreaRandomRecording ‑ test_read
tests.musicbrainz.test_ac_id_lookup.TestArtistCreditNameLookup ‑ test_read
tests.musicbrainz.test_genre_lookup.TestGenreLookup ‑ test_read
tests.musicbrainz.test_year_lookup.TestYearLookup ‑ test_read
tests.musicbrainz.test_year_lookup.TestYearLookup ‑ test_read_keep_unmatched
tests.musicbrainz.test_year_lookup.TestYearLookup ‑ test_read_remove_unmatched
tests.test_entities.TestEntities ‑ test_artist_credit

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Package Line Rate Complexity Health
. 35% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 26% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 35% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 26% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 35% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 26% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 35% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 45% 0
musicbrainz 71% 0
patches 26% 0
patches.lb_radio_classes 0% 0
tools 74% 0
Summary 23% (4172 / 17989) 0

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

troi/operations.py Outdated Show resolved Hide resolved
troi/listenbrainz/unused/dataset_fetcher.py Outdated Show resolved Hide resolved
troi/__init__.py Show resolved Hide resolved
troi/__init__.py Show resolved Hide resolved
troi/__init__.py Outdated Show resolved Hide resolved
troi/patches/periodic_jams.py Outdated Show resolved Hide resolved
@mayhem mayhem merged commit 57036ac into main Apr 12, 2024
1 of 5 checks passed
@mayhem mayhem deleted the fix-artist-object branch April 12, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants