-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ArtistCredit, cleanup old cruft and use MB recording cache #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
others. Get rid of unused artist credit id lookup element.
…endation-playground into fix-artist-object
Test Results 4 files ± 0 4 suites ±0 4s ⏱️ ±0s Results for commit a5cfedb. ± Comparison against base commit a262451. This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
amCap1712
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather large PR (sorry!) creates a new ArtistCredit object that should've been created a long time ago. All existing code has now been refactored to use ArtistCredits.
There were several modules no longer in use, for endpoints that no longer existed. Cleaned up.
Finally the recording_lookup now uses the MB Recording Cache, which makes everything faster and merges tag and year lookup into one concise module.
More work will be needed to make a new LB Radio release, but once that is complete, then we'll release Troi 1.0!