-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dates from the thesaurus file if exists instead of file system last modified date from thesaurusDate #327
Use dates from the thesaurus file if exists instead of file system last modified date from thesaurusDate #327
Conversation
Related to #329 |
Probably relevant to update https://github.com/metadata101/iso19139.ca.HNAP/blob/3.12.x/src/main/config/codelist/local/thesauri/theme/GC_Core_Subject.rdf as part of this pull request with the relevant dates. |
Yes, the thesaurus file itself needs to be updated. I was thinking to do in a separate PR or if you prefer, I can do into this PR. I am also trying to define what date to put into this file. |
This is related to the following issue Once the correct date is identified then we can create a new PR to apply the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the <gmd:date>
was created by a function so that it would remove a lot of duplicated code however overall - I have tested and it works as expected.
If we don't want to wait for related issue #329 , then we can do as @josegar74 suggested and just use the existing values. And when issue #329 identifies the correct dates then we can create another PR to apply the correct dates.
|
I added the default date to the GC_Core thesaurus file. Also group the logics to a single function. Tested and works fine. @ianwallen |
…st modified date from thesaurusDate (#327) * Exclude file system last modified date from thesaurusDate * thesaurusDate * default HNAP template date to GC_Core_Subject.rdf * default HNAP template date to GC_Core_Subject.rdf . * group duplicate date parsing logic to single function
This is to fix the issue #308
Also depends on this PR geonetwork/core-geonetwork#6972
Once Geonetwork passed isFilesystemDate flag into the HNAP schema. HNAP will be able to parse it or discard it.