Allow empty values in setreplace map (#420) #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing empty values in the map enables the SetReplacer to remove matching keys. Also fixes setting the separator by using an init() to avoid loading the map without taking all settings into account. Adds a rule to .editorconfig to allow the test map having trailing tabs.
blackwinter
approved these changes
Nov 24, 2021
blackwinter
added a commit
to metafacture/metafacture-fix
that referenced
this pull request
Oct 20, 2022
blackwinter
added a commit
to metafacture/metafacture-fix
that referenced
this pull request
Oct 21, 2022
dr0i
pushed a commit
to metafacture/metafacture-fix
that referenced
this pull request
Nov 11, 2022
blackwinter
added a commit
to metafacture/metafacture-fix
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing empty values in the map enables the SetReplacer to remove matching
keys.
Also fixes setting the separator by using an init() to avoid loading the map
without taking all settings into account.
Adds a rule to .editorconfig to allow the test map having trailing tabs.