Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update BroadcastMessage to avoid alloc #40

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

szpnygo
Copy link
Contributor

@szpnygo szpnygo commented Oct 19, 2022

only encode once in BroadcastMessage to avoid alloc objects

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #40 (b1ae995) into main (c2b5f15) will decrease coverage by 1.71%.
The diff coverage is 17.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   60.95%   59.23%   -1.72%     
==========================================
  Files          68       67       -1     
  Lines        2876     2971      +95     
==========================================
+ Hits         1753     1760       +7     
- Misses        981     1065      +84     
- Partials      142      146       +4     
Impacted Files Coverage Δ
app.go 72.72% <ø> (-1.81%) ⬇️
e2e/performance/main.go 0.00% <0.00%> (ø)
static.go 46.51% <60.86%> (ø)
agent/agent.go 51.47% <75.00%> (+0.71%) ⬆️
builder.go 100.00% <100.00%> (ø)
session/session.go 75.00% <100.00%> (+1.19%) ⬆️
codec/codec.go 80.00% <0.00%> (-1.82%) ⬇️

@szpnygo szpnygo merged commit 9fb2cd4 into main Oct 19, 2022
@szpnygo szpnygo deleted the feature/performance branch October 19, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant