Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ocm-dimensions] Minimal conf for NodeJs+Docker #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ocm-dimensions] Minimal conf for NodeJs+Docker #7

wants to merge 1 commit into from

Conversation

netzulo
Copy link

@netzulo netzulo commented Jul 6, 2023 •
edited
Loading

Related to #6

  • ready for review
  • ready for merge

@netzulo netzulo mentioned this pull request Jul 6, 2023
Open
@netzulo
Copy link
Author

netzulo commented Jul 6, 2023 •
edited
Loading

i can't ensure if it's ready to merge without owner checks , please @huuep if you can help me to decide

  • Maybe i must implement package json for p5js, or maybe globally.
  • We will need a configurable PATH for model ? we can got this too if need it
  • I'm doing well at start this HTML down nginx ? i can't view after "compress" but i think it's an error from my environment so i discard for the moment

Lulumoons
Lulumoons reviewed Jul 13, 2023
View reviewed changes
Copy link

@Lulumoons Lulumoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulumoons Lulumoons Lulumoons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netzulo @Lulumoons