Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send DM about all the channels to new users #1

Merged
merged 13 commits into from
Mar 17, 2017

Conversation

icyflame
Copy link
Member

Please have a look at the message. You can get this message inside slack by sending send the joining message to me to @eva on Slack.

cc @amrav @nevinvalsaraj @hargup @vivekiitkgp @DefCon-007 @athityakumar

amrav
amrav previously requested changes Oct 12, 2016
Copy link
Member

@amrav amrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :)

@@ -12,6 +12,11 @@ has, etc!
[hubot]: http://hubot.github.com
[generator-hubot]: https://github.com/github/generator-hubot

### Present Setup

This is deployed on Heroku. The name of the app is `metakgp-eva`. Contact @amrav
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be clarified to say that anyone can open pull requests, but only a few people can push the changes. I would prefer not to be the primary contact for pushing changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry. I think I was in the middle of writing a sentence there. Yeah, I am removing this. Just letting people know that it is hosted on Heroku. PRs on GitHub are still the way to go!

@@ -32,6 +32,20 @@ welcome_message_3 = [
" Why don't you tell us a bit about you?"
]

channels_info = [
Copy link
Member

@amrav amrav Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if you can get the channel names and short descriptions from slack automatically. This should be a map from channel name to long description, and then construct this message programmatically. That way Eva can respond to requests for long descriptions of individual channels as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrav The channel descriptions are already in slack. This message is more of a primer of the channels that are active currently so that people can join immediately.

If you are thinking something like handwritten long messages for each channel which people can ask for from Eva, that's completely different. Tell me which one you had in mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the behaviour I'm thinking of:

  1. When somebody joins Slack for the first time, they get a DM with a list of channels and their short descriptions. This is so that they don't have to browse through all the channels to know which ones exist and what they're for.
  2. They can also do eva help <channel name>, which will give them a longer description of a channel.
  3. The longer description should also automatically be sent whenever you join a channel for the first time.

This is designed to give a newcomer a decent overview, and also understand how to use the channels they join. Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I understand the idea. Question. Are these short descriptions the Slack channel's description themselves, or are they something else?

Clearly, we would need a long description map for each channel. This should not be too hard to write once we have a basic framework to work around with.

@icyflame
Copy link
Member Author

@amrav Long descriptions implemented. For some reason, the sending of descriptions on people entering a channel is not working, despite being in the same block:

https://github.com/icyflame/eva/blob/b2269270229471f30e79185cd5f5e30d1d461971/scripts/welcome.coffee#L81-L86

Will investigate some more. We need to fill out the JSON file with the long descriptions.

cc @hargup @vivekiitkgp

@icyflame icyflame dismissed amrav’s stale review October 24, 2016 11:18

Changes have been implemented

@hargup
Copy link
Member

hargup commented Mar 9, 2017

@icyflame have you figured out what was wrong? This is very pretty cool feature to have.

@icyflame
Copy link
Member Author

@hargup No, this is the version that is deployed right now, so I think we should merge this in, while I continue to work on the message that is sent when people enter channels. That's a different feature, so it's fine, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants