Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from links to networks #49

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

icyflame
Copy link
Member

@icyflame icyflame commented Nov 13, 2018

links is deprecated in Docker: https://docs.docker.com/network/links/

image

This is the network diagram (the arrows represent the old links, and the annotations near the arrows represent the name of the network that allows those connections)

Imgur

I tested this by running docker-compose locally, and then opening the wiki and making an edit / checking that pages were there. (I used a mysql backup of the wiki to test this stuff)

@icyflame
Copy link
Member Author

icyflame commented Nov 13, 2018

For some reason, GitHub is displaying my image rotated. The actual image has the proper orientation. Strange.

Anyway, changed the link to one on Imgur.

@sam17
Copy link

sam17 commented Nov 13, 2018

Why not used depends_on ? Also, we seem to not have health status for the container to check if they are up. We should add them maybe?

@icyflame
Copy link
Member Author

@sam17 Why do you want to use depends_on? 🤔 These are simply connected over the network. If the other container is down, the app won't work. But there is no need to start them in a particular sequence.

(I don't know about the health status feature, can you please open an issue describing how it might help us? 🙌 )

@thealphadollar
Copy link
Contributor

@icyflame @sam17 Please update.

@thealphadollar thealphadollar merged commit e4c2a26 into master Jul 16, 2019
@thealphadollar thealphadollar deleted the icyflame/networks-instead-of-links branch July 16, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants