Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proto Makefile #101

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Fix proto Makefile #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24684d6
Fix proto Makefile
majst01 Feb 14, 2023
4ec3dbd
Check for uncommited changes
majst01 Feb 14, 2023
4966941
Check for uncommited changes
majst01 Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,19 @@ jobs:
with:
args: -p bugs -p unused --timeout=3m

- name: break if proto modifications where not committed
run: |
make proto
- name: Check if there are changes
uses: UnicornGlobal/has-changes-action@v1.0.12
- name: Process changes
if: steps.changes.outputs.changed == 1
run: echo "Changes exist"

- name: build and test
run: |
make test
make bench

make

- name: Publish Codecoverage report
run: bash <(curl -s https://codecov.io/bash)

Expand Down
6 changes: 3 additions & 3 deletions proto/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ _buf:

.PHONY: protolint
protolint:
@$(MAKE) buf CMD="format -w api/v1"
@$(MAKE) buf CMD="lint -v"
@$(MAKE) _buf CMD="format -w api/v1"
@$(MAKE) _buf CMD="lint -v"

.PHONY: protoc
protoc: protolint
@$(MAKE) buf CMD="generate -v"
@$(MAKE) _buf CMD="generate -v"