Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Audit Logs in metalctl audit ls #186

Closed
vknabel opened this issue Mar 2, 2023 · 1 comment
Closed

Expose Audit Logs in metalctl audit ls #186

vknabel opened this issue Mar 2, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@vknabel
Copy link
Contributor

vknabel commented Mar 2, 2023

Meilisearch does only provide a searchable web frontend when running in development mode. We want to avoid this and a little bit more convenience.

The approach is to add a subcommand to metalctl to show audit logs: metalctl audit ls.

@vknabel vknabel added the enhancement New feature or request label Mar 2, 2023
@Gerrit91
Copy link
Contributor

Gerrit91 commented Mar 2, 2023

Flags that should be available for the user to filter down search results:

  • --request-id 3c56f318-95aa-49c2-afba-53e0336cbb3a (string starts-with)
  • --path /v1/image (free search in path field)
  • --user user@metal-stack.io (exact match?)
  • --tenant metal-stack.io (exact match?)
  • --from "2023-02-01 15:23:34" --to "2023-02-01 16:45:57" (defaults to time.Now() - 1h)
  • --body "something" (free text searches on body and response fields)
  • ...?

Changes we have to make for the fields in meilisearch:

  • Factor out field names into constants / form a common search query struct for the interface?
    • Maybe consider interface refactoring?
  • Add unix timestamp to have time searchable queries
  • Disable typo tolerance
  • Remove duplicate request body from response entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants