Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v2 based on changes in main #145

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update v2 based on changes in main #145

merged 3 commits into from
Sep 1, 2023

Conversation

joelrebel
Copy link
Member

@joelrebel joelrebel commented Aug 29, 2023

What does this PR do

Cherry picked changes from main to keep v2 up to date with features and fixes.

diogomatsubara and others added 3 commits August 29, 2023 06:50
…n namespaces (#119)

* Split status and firmware versioned attributes

this change splits the status and firmware versioned attributes into
their own namespaces. The firmware VA data is a single object while
the status VA data is an array.

* Update fixture and tests
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as far as it goes. Writing mocks and maintaining them by hand sucks, and if we could move to gomock it'd be better IMO. That can wait for some follow-on work.

internal/device/inband/mock.go Show resolved Hide resolved
@joelrebel joelrebel merged commit 3aeb488 into v2 Sep 1, 2023
4 of 6 checks passed
@joelrebel joelrebel deleted the v2-rebase-main-01 branch September 1, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants