Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 bump gosec to 2.18.2 #1474

Merged
merged 1 commit into from
Dec 5, 2023
Merged

馃尡 bump gosec to 2.18.2 #1474

merged 1 commit into from
Dec 5, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 1, 2023

Bump gosec to 2.18.2

@tuminoid
bump gosec to 2.18.2
dcc132e 
Bump gosec to 2.18.2

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
tuminoid added a commit to Nordix/baremetal-operator that referenced this pull request Dec 1, 2023
@tuminoid
bump gosec to 2.18.2
7facfa1 
Manual cherry-pick of metal3-io#1474.

It also backports metal3-io#1362 that makes gosec.sh actually do something
for non-root modules.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid mentioned this pull request Dec 1, 2023
Merged
tuminoid added a commit to Nordix/baremetal-operator that referenced this pull request Dec 1, 2023
@tuminoid
bump gosec to 2.18.2
9b8fbad 
Manual cherry-pick of metal3-io#1474.

It also backports metal3-io#1362 that makes gosec.sh actually do something for
non-root modules.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid mentioned this pull request Dec 1, 2023
Merged
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main
Not tested by integration tests.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main
Not tested by integration tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rozzii
Rozzii approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Dec 4, 2023
Merged
kashifest
kashifest reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@zhouhao3
Copy link
Member

zhouhao3 commented Dec 5, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@metal3-io-bot metal3-io-bot merged commit e660da2 into metal3-io:main Dec 5, 2023
14 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-gosec branch December 5, 2023 01:41
maxrantil added a commit to Nordix/baremetal-operator that referenced this pull request Dec 7, 2023
@maxrantil
fixup! Merge pull request metal3-io#1474 from Nordix/tuomo/bump-gosec
ff66009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tuminoid @metal3-io-bot @zhouhao3 @Rozzii @kashifest