Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 bump gosec to 2.18.2 #1475

Merged
merged 1 commit into from Dec 5, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 1, 2023

Manual cherry-pick of #1474.

It also backports #1362 that makes gosec.sh actually do something for non-root modules.

Manual cherry-pick of metal3-io#1474.

It also backports metal3-io#1362 that makes gosec.sh actually do something
for non-root modules.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/override test-centos-e2e-integration-1-5
/override test-ubuntu-integration-1-5
Not tested by integration tests.

@metal3-io-bot
Copy link
Contributor

@tuminoid: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • test-centos-e2e-integration-1-5
  • test-ubuntu-integration-1-5

Only the following failed contexts/checkruns were expected:

  • generate
  • gofmt
  • golint
  • gomod
  • gosec
  • manifestlint
  • shellcheck
  • test-centos-e2e-integration-release-1-5
  • test-ubuntu-integration-release-1-5
  • tide
  • unit

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override test-centos-e2e-integration-1-5
/override test-ubuntu-integration-1-5
Not tested by integration tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

tuminoid commented Dec 1, 2023

/override test-centos-e2e-integration-release-1-5
/override test-ubuntu-integration-release-1-5
Not tested by integration tests.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-release-1-5, test-ubuntu-integration-release-1-5

In response to this:

/override test-centos-e2e-integration-release-1-5
/override test-ubuntu-integration-release-1-5
Not tested by integration tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@zhouhao3
Copy link
Member

zhouhao3 commented Dec 5, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@metal3-io-bot metal3-io-bot merged commit a0f5868 into metal3-io:release-0.4 Dec 5, 2023
11 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-gosec-0.4 branch December 5, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants