Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gosec to 2.18.2 #603

Merged
merged 1 commit into from
Dec 5, 2023
Merged

bump gosec to 2.18.2 #603

merged 1 commit into from
Dec 5, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 4, 2023

Bump gosec to 2.18.2 for BMO.

Do not bump CAPM3/IPAM gosec as it is used in release-1.3 and 1.4, but release-1.3 is no longer maintained, and hence we'd need to fork the project-infra config between the two. 1.4 is also going to be moved out of support soon when 1.6 releases.

/hold
Needs:
metal3-io/baremetal-operator#1476, metal3-io/baremetal-operator#1475, metal3-io/baremetal-operator#1474 to merge first.

@tuminoid
bump gosec to 2.18.2
f5bbde5 
Bump gosec to 2.18.2 for BMO.
Do not bump CAPM3/IPAM gosec as it is used in release-1.3 and 1.4, but
release-1.3 is no longer maintained, and hence we'd need to fork the
project-infra config between the two. 1.4 is also going to be moved
out of support soon when 1.6 releases.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Dec 5, 2023

/unhold
BMO PRs have merged.

/override test-ubuntu-integration-main
Not tested by integration.

/cc @lentzi90 @kashifest

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/unhold
BMO PRs have merged.

/override test-ubuntu-integration-main
Not tested by integration.

/cc @lentzi90 @kashifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rozzii
Rozzii approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
lentzi90
lentzi90 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@metal3-io-bot metal3-io-bot merged commit 2041720 into metal3-io:main Dec 5, 2023
4 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Bump gosec to 2.18.2 for BMO.

Do not bump CAPM3/IPAM gosec as it is used in release-1.3 and 1.4, but release-1.3 is no longer maintained, and hence we'd need to fork the project-infra config between the two. 1.4 is also going to be moved out of support soon when 1.6 releases.

/hold
Needs:
metal3-io/baremetal-operator#1476, metal3-io/baremetal-operator#1475, metal3-io/baremetal-operator#1474 to merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/bump-gosec branch January 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Rozzii approved these changes

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tuminoid @metal3-io-bot @lentzi90 @Rozzii