Makefile updates for docker build and push, and release manifests generation. #405
Conversation
* Docker build and push commands that align with CAPI model. * Release manifests generation. Issue: metal3-io#404
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Arvinderpal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
|
Hi @Arvinderpal. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metal3-io-bot
added
the
needs-ok-to-test
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
metal3-io-bot
added
the
lifecycle/stale
| docker-build: ## Build the docker image for controller-manager | ||
| docker build --pull --build-arg ARCH=$(ARCH) -f build/Dockerfile -t $(CONTROLLER_IMG)-$(ARCH):$(TAG) . | ||
| MANIFEST_IMG=$(CONTROLLER_IMG)-$(ARCH) MANIFEST_TAG=$(TAG) $(MAKE) set-manifest-image | ||
| $(MAKE) set-manifest-pull-policy | ||
|
|
||
| .PHONY: docker-push | ||
| docker-push: ## Push the docker image | ||
| docker push $(CONTROLLER_IMG)-$(ARCH):$(TAG) |
There was a problem hiding this comment.
for this to work with quay.io, we would need to create a new repository on quay.io since the image would be renamed from baremetal-operator to baremetal-operator-amd64. If that is the only architecture supported for now, I don't really see the point of renaming though. That could be done when other architectures are introduced.
|
Stale issues close after 30d of inactivity. Reopen the issue with /close |
|
@metal3-io-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes introduced:
This is the first PR that brings us closer to having release model similar to that of CAPI. See Issue: #404