Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define release guidelines for baremetal-operator and start publishing releases #71

Closed
2 tasks
Arvinderpal opened this issue Jan 29, 2020 · 23 comments
Closed
2 tasks
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@Arvinderpal
Copy link
Contributor

Arvinderpal commented Jan 29, 2020

We should adopt a releasing approach similar to that of CAPI and follow the well-known semantic versioning guidelines (see references below).

Besides this being a good practice, integration with the redesigned clusterctl will require that projects follow the above mentioned releasing strategy. A similar issue was created for capbm: metal3-io/cluster-api-provider-baremetal#224

PR Tracking:

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@dhellmann
Copy link
Member

/remove-lifecycle stale
/lifecycle freeze

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2020
@metal3-io-bot
Copy link
Contributor

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Contributor

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb
Copy link
Member

reopened, since this is still relevant

@metal3-io-bot
Copy link
Contributor

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Contributor

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Member

Reopening, since this has not been solved yet and still relevant

@fmuyassarov fmuyassarov reopened this Jul 19, 2022
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Jul 19, 2022
@Rozzii
Copy link
Member

Rozzii commented Jul 20, 2022

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jul 20, 2022
@Rozzii
Copy link
Member

Rozzii commented Jul 20, 2022

/remove-lifecycle stale

@fmuyassarov
Copy link
Member

Yesterday during the community meeting we discussed the process of starting Baremetal Operator project releases. We are going to follow the widespread semantic versioning scheme and since we have not yet announced BMO as stable we would like to have more frequent and smaller releases for now and when we reach the stability we would like to stick to the same release cycle as Kubernetes (3 times a year). But we will discuss it again when the time comes for that.

To start with, our MAJOR version will be 0, until we feel that the codebase is stable enough for the production. As such, we could start with MINOR version 0.1.0 and continue incrementing from there.

Main branch will be for development while release-MINOR.PATCH branch is for stable, tested and backwards compatible code. Whenever there is a new major or minor release, a new branch will be created with release-MINOR.PATCH name.

@s3rj1k
Copy link
Member

s3rj1k commented Jul 21, 2022

@fmuyassarov major version 0 can be an issue for go.mod

Are we sure that that kind of release versioning will be compatible for go.mod usage?

@fmuyassarov
Copy link
Member

What is the issue? We have been using it in CAPM3 until now.

@s3rj1k
Copy link
Member

s3rj1k commented Jul 21, 2022

What is the issue? We have been using it in CAPM3 until now.

https://go.dev/doc/modules/version-numbers

Hmm, you are correct as per the link above.

I assume possible issue can be with v0 to v1 (creating a branch or subfolder)

@fmuyassarov
Copy link
Member

What is the issue? We have been using it in CAPM3 until now.

https://go.dev/doc/modules/version-numbers

Hmm, you are correct as per the link above.

I assume possible issue can be with v0 to v1 (creating a branch or subfolder)

I don't see an issue in branching as well to be honest. But after your point, I realized that branch naming should not be release-MINOR.PATCH but instead release-MAJOR.MINOR because each MINOR can have 0,1,3..9 PATCH releases, and we don't want to create a branch for every single patch release. I will make correction on my email and thanks for pointing out.

@s3rj1k
Copy link
Member

s3rj1k commented Jul 21, 2022

@fmuyassarov I was pointing out that go expects that new Major release should be in separate branch or subfolder and named as Major version value.

So transition for v0 to v1, according to golang spec, we would need to put newer code in new branch named v1 or into subfolder v1.

Not sure that this is actually needed for v0 to v1, pretty much sure that this is needed for v1 to v2 transition.

@Rozzii
Copy link
Member

Rozzii commented Aug 3, 2022

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2022
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2022
@Rozzii
Copy link
Member

Rozzii commented Nov 2, 2022

I would close this I think this issue has been resolved but please give your opinion.

@furkatgofurov7
Copy link
Member

I would close this I think this issue has been resolved but please give your opinion.

+1

@Rozzii
Copy link
Member

Rozzii commented Nov 16, 2022

We have started releasing BMO and we have a release guideline in review metal3-io/baremetal-operator#1170.
/close

@metal3-io-bot
Copy link
Contributor

@Rozzii: Closing this issue.

In response to this:

We have started releasing BMO and we have a release guideline in review metal3-io/baremetal-operator#1170.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

9 participants