Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iptables filters from ironic containers #104

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

derekhiggins
Copy link
Member

We don't appear to need these, infact they output
errors on container startup...

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2019
@derekhiggins
Copy link
Member Author

/hold
will run through ci once this merges openshift-metal3/dev-scripts#826

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2019
@metal3ci
Copy link

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1215/

@russellb
Copy link
Member

Once it's working and you remove the hold, /lgtm

@russellb
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2019
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@metal3ci
Copy link

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1242/

@derekhiggins
Copy link
Member Author

/lgtm
ci failed in 12_csr_hack.sh

@metal3-io-bot
Copy link
Contributor

@derekhiggins: you cannot LGTM your own PR.

In response to this:

/lgtm
ci failed in 12_csr_hack.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
We don't appear to need these, infact they output
errors on container startup...
@metal3ci
Copy link

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1327/

@hardys
Copy link
Member

hardys commented Nov 25, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@metal3-io-bot metal3-io-bot merged commit 9d8efc4 into metal3-io:master Nov 25, 2019
@hardys hardys mentioned this pull request Nov 25, 2019
hardys pushed a commit to hardys/ironic-image that referenced this pull request Nov 26, 2019
We don't appear to need these, infact they output
errors on container startup...

Related metal3-io change metal3-io#104
(cherry picked from commit f380833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. CI lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants