-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to split up Ironic container #16
Conversation
runhealthcheck.sh
Outdated
|
||
curl -s http://172.22.0.1:6385 > /dev/null || ( echo "Can't contact ironic-api" && exit 1 ) | ||
elif [ $1 = "ironic" ] ; then | ||
curl -s http://172.22.0.1:6385 > /dev/null || ( echo "Can't contact ironic-api" && exit 1 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can just make this such it looks at the IP in the container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use localhost for just testing response on this port.
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/348/ |
fe9eafa
to
b7164aa
Compare
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/354/ |
#!/usr/bin/bash | ||
|
||
rmdir /var/www/html | ||
ln -s /shared/html/ /var/www/html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could probably go to the httpd configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll change this in follow-on patch that will change the http port we're using.
@@ -1,8 +1,6 @@ | |||
#!/usr/bin/bash | |||
/usr/bin/python2 /usr/bin/ironic-conductor > /var/log/ironic-conductor.out 2>&1 & | |||
/usr/bin/python2 /usr/bin/ironic-api > /var/log/ironic-api.out 2>&1 & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way to split this out. Or even better, just run it under httpd as a wsgi application (which is anyway the recommended way to run ironic: https://docs.openstack.org/ironic/latest/install/install-rdo.html#configuring-ironic-api-behind-mod-wsgi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think using wsgi makes sense which is how we do it with tripleo, and splitting it out will allow one set of logs from this container. OK to do in a follow-on patch with above changes?
Allows Ironic container to be split between ironic, dnsmasq, and httpd containers using this same image.
b7164aa
to
a7a549a
Compare
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/371/ |
Doesn't appear to be working - the http request fails downloading the image with Failed connect to 172.22.0.1:80; Connection refused ? |
Did you include the dev-scripts changes at the same time (openshift-metal3/dev-scripts#204)? The dev-scripts change is needed to start the httpd container, which sounds like its not happening. |
Allows Ironic container to be split between ironic, dnsmasq, and httpd
containers using this same image.